Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny style issue: icon in personal settings in blue button on the bottom is grey, not white #24450

Closed
jospoortvliet opened this issue Nov 30, 2020 · 10 comments · Fixed by #25119, #25245 or #25376
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info papercut Annoying recurring issue with possibly simple fix.

Comments

@jospoortvliet
Copy link
Member

It's a papercut, but it just looks off:
Screenshot_20201130_132052

@MorrisJobke MorrisJobke added this to the Nextcloud 20.0.3 milestone Nov 30, 2020
@MorrisJobke MorrisJobke added design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix. labels Nov 30, 2020
@96RadhikaJadhav
Copy link

Could you please assign this issue to me and direct me to the file where it can be changed?

@Zhoha28
Copy link

Zhoha28 commented Dec 3, 2020

Hi, I would like to work on this, if anyone has not been assigned to this yet

@BrookeDot
Copy link
Member

Hi @96RadhikaJadhav or @Zhoha28 are either of you actively working on this? If not, I may give it a go. While I'm not intimately familiar with the code I did some searching on GitHub and think I found the right files:

HTML:

<a href="<?php p($_['reasons-use-nextcloud-pdf-link']); ?>" id="open-reasons-use-nextcloud-pdf" class="link-button icon-file" target="_blank"><?php p($l->t('Reasons to use Nextcloud in your organization'));?></a>

SASS:

.link-button {
display: inline-block;
margin: 16px;
padding: 14px 20px;
background-color: var(--color-primary);
color: #fff;
border-radius: var(--border-radius-pill);
border: 1px solid var(--color-primary);
box-shadow: 0 2px 9px var(--color-box-shadow);
&:active,
&:hover,
&:focus {
color: var(--color-primary);
background-color: var(--color-primary-text);
border-color: var(--color-primary) !important;
}
&.icon-file {
padding-left: 48px;
background-position: 24px;
}
}

@skjnldsv skjnldsv added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 30, 2020
@RafaOP
Copy link

RafaOP commented Jan 7, 2021

While the icon does look off in grey, the button fades to white on mouseover. Changing the icon to white would make it white on a white background.

RafaOP added a commit to RafaOP/server that referenced this issue Jan 8, 2021
RafaOP added a commit to RafaOP/server that referenced this issue Jan 8, 2021
… otherwise.

Signed-off-by: Rafael Oliveira Pereira <rafa.oliveirap@gmail.com>
@RafaOP
Copy link

RafaOP commented Jan 19, 2021

Hey @MorrisJobke, can you take a look at my request when you're available?

@MorrisJobke
Copy link
Member

Hey @MorrisJobke, can you take a look at my request when you're available?

Sure :) I mentioned some people :)

@MorrisJobke MorrisJobke removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 19, 2021
@RafaOP
Copy link

RafaOP commented Jan 20, 2021

Thanks!

@rullzer rullzer mentioned this issue Jan 21, 2021
15 tasks
@rullzer rullzer mentioned this issue Jan 21, 2021
19 tasks
@rullzer rullzer mentioned this issue Jan 29, 2021
@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2021

Closed accidentally in #25119, but #25023 is still open

@J0WI J0WI reopened this Apr 28, 2021
RafaOP added a commit to RafaOP/server that referenced this issue May 10, 2021
@szaimen szaimen added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label May 20, 2021
RafaOP added a commit to RafaOP/server that referenced this issue May 29, 2021
@skjnldsv skjnldsv removed this from the Nextcloud 21 milestone Jul 5, 2021
RafaOP added a commit to RafaOP/server that referenced this issue Jul 6, 2021
… otherwise.

Signed-off-by: Rafael Oliveira Pereira <rafa.oliveirap@gmail.com>
RafaOP added a commit to RafaOP/server that referenced this issue Jul 6, 2021
@szaimen szaimen added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 8, 2021
@Ayushbajpai19
Copy link

I would like to take this issue for hacktoberfest

@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Jan 23, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info papercut Annoying recurring issue with possibly simple fix.
Projects
None yet