Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing german translation - Settings of a share #25490

Closed
blackerking opened this issue Feb 5, 2021 · 3 comments
Closed

Missing german translation - Settings of a share #25490

blackerking opened this issue Feb 5, 2021 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@blackerking
Copy link

Missing german translation if you change settings of share:
grafik
@blackerking blackerking added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 5, 2021
@kesselb kesselb added 1. to develop Accepted and waiting to be taken care of good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 5, 2021
@kesselb
Copy link
Contributor

kesselb commented Feb 5, 2021

Code

server/lib/private/Share20/Manager.php

Line 545 in 6846a83

throw new \Exception('Sharing is only allowed with group members');

Example how to translate a exception message

server/lib/private/Share20/Manager.php

Lines 291 to 292 in 6846a83

$message_t = $this->l->t('You are not allowed to share %s', [$share->getNode()->getName()]);
throw new GenericShareException($message_t, $message_t, 404);

faust64 added a commit to Worteks/server that referenced this issue Feb 5, 2021
@faust64
fix(translation): replace static error message
59e43b4 
as suggested by @kesselb in nextcloud#25490

Signed-off-by: Samuel <faust64@gmail.com>
@faust64 faust64 mentioned this issue Feb 5, 2021
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Feb 5, 2021
@faust64 @backportbot
fix(translation): replace static error message
038def2 
as suggested by @kesselb in #25490

Signed-off-by: Samuel <faust64@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Mar 30, 2021
@faust64 @backportbot
fix(translation): replace static error message
22ddcfa 
as suggested by @kesselb in #25490

Signed-off-by: Samuel <faust64@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this issue Mar 30, 2021
@faust64 @backportbot
fix(translation): replace static error message
2703777 
as suggested by @kesselb in #25490

Signed-off-by: Samuel <faust64@gmail.com>
@rakekniven
Copy link
Member

This can be closed, or?

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

looks like it, yes 👍

@szaimen szaimen closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blackerking @rakekniven @kesselb @szaimen