-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise for all teams: use display name cache #33589
Comments
IUserManager::getDisplayName is a heavily cached method. When only the display name of a user is required. It reduces roughly 1-2 query per existing user backend database queries. The method is new in 25, so when the minimum version of the app allows it please use this. Prime examples as per above are rendering activities and notifications and similar things. Please raise for your teams and apps:
|
does LazyUser also count as display name cache ? because I saw a bunch of PRs from @icewind1991 for using that as well |
Yes, LazyUser uses the cache iirc |
@PVince81 shall we close as all teams reacted? You can create a follow up for server if you think it makes sense, but a generic ticket for server is probably also not helpful and fixes must be applied once a spot is found. |
The text was updated successfully, but these errors were encountered: