Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user name cache in activity providers #33615

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Use user name cache in activity providers #33615

merged 1 commit into from
Aug 19, 2022

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Aug 18, 2022
@nickvergessen nickvergessen mentioned this pull request Aug 18, 2022
Closed
tcitworld
tcitworld reviewed Aug 19, 2022
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you think we need to keep the protected method for classes that could extend them, but I didn't see any in all of the code here.

If so anyway, disregard all comments.

apps/comments/lib/Activity/Provider.php Outdated Show resolved Hide resolved
apps/dav/lib/CalDAV/Activity/Provider/Base.php Outdated Show resolved Hide resolved
apps/dav/lib/CardDAV/Activity/Provider/Base.php Outdated Show resolved Hide resolved
apps/settings/lib/Activity/GroupProvider.php Outdated Show resolved Hide resolved
apps/settings/lib/Activity/Provider.php Outdated Show resolved Hide resolved
apps/sharebymail/lib/Activity.php Outdated Show resolved Hide resolved
apps/systemtags/lib/Activity/Provider.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the perf/noid/user-displayname-cache-for-activity-providers branch from 1893202 to 5080732 Compare August 19, 2022 08:47
@nickvergessen
Use user name cache in activity providers
7e11778 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the perf/noid/user-displayname-cache-for-activity-providers branch from 5080732 to 7e11778 Compare August 19, 2022 08:48
@tcitworld
Copy link
Member

Samba tests errors seems unrelated.

@nickvergessen nickvergessen merged commit 71065f5 into master Aug 19, 2022
@nickvergessen nickvergessen deleted the perf/noid/user-displayname-cache-for-activity-providers branch August 19, 2022 10:28
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2022
Merged
@tcitworld tcitworld mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification performance 🚀
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @tcitworld @CarlSchwan