Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share link not removed from share overview when using delete button #40396

Closed
szaimen opened this issue Sep 13, 2023 · 3 comments · Fixed by #40440
Closed

share link not removed from share overview when using delete button #40396

szaimen opened this issue Sep 13, 2023 · 3 comments · Fixed by #40440
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug design Design, UI, UX, etc. feature: sharing regression

Comments

@szaimen
Copy link
Contributor

szaimen commented Sep 13, 2023

See

Aufzeichnung.2023-09-13.170617.mp4
@szaimen szaimen added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: sharing regression 27-feedback labels Sep 13, 2023
@szaimen szaimen added this to the Nextcloud 27.1.0 milestone Sep 13, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Sep 15, 2023

Cc @AndyScherzinger @sorbaugh

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Sep 15, 2023

@szaimen Thanks for reporting this, would send in a fix for this soon

Fenn-CS added a commit that referenced this issue Sep 15, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Sep 15, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Fenn-CS added a commit that referenced this issue Sep 15, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Sep 15, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Fenn-CS added a commit that referenced this issue Sep 15, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command pushed a commit that referenced this issue Sep 18, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : #40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Sep 19, 2023

Fixed with #40448

@szaimen szaimen closed this as completed Sep 19, 2023
zak39 pushed a commit to arawa/server that referenced this issue Oct 11, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : nextcloud#40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
Currently, the `removeShare` method in the `SharingTab` view,
does not take into account `linkShares`.

Since link shares now shares thesame detail view with other share types,
it should therefore be considered hence this commit.

Resolves : nextcloud#40396

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug design Design, UI, UX, etc. feature: sharing regression
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants