Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug 27.1 RC3]: File drop shows all files per default #40431

Closed
5 of 8 tasks
enoch85 opened this issue Sep 15, 2023 · 4 comments · Fixed by #40434
Closed
5 of 8 tasks

[Bug 27.1 RC3]: File drop shows all files per default #40431

enoch85 opened this issue Sep 15, 2023 · 4 comments · Fixed by #40434
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing regression
Milestone
Nextcloud 27.1.0

Comments

@enoch85
Copy link
Member

enoch85 commented Sep 15, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

When creating a new File Drop share, the default behavior is that the files are shown.

Steps to reproduce

  1. Share a folder as usual
  2. Set File upload

Expected behavior

The end user should only see an upload button.

Installation method

Other Community project

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

N/A (reportimg from mobile)

List of activated Apps

N/A (reportimg from mobile)

Nextcloud Signing status

N/A (reportimg from mobile)

Nextcloud Logs

N/A (reportimg from mobile)

Additional info

cc @small1
@enoch85 enoch85 added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2023
@szaimen szaimen added this to the Nextcloud 27.1.0 milestone Sep 15, 2023
@szaimen
Copy link
Contributor

szaimen commented Sep 15, 2023

cc @AndyScherzinger @sorbaugh @Fenn-CS

@small1
Copy link

small1 commented Sep 15, 2023

Just tested some more. File drop works as it should when you select it below the share link text. If you click on customize it might say custom permissions instead of drop folder.

If you change from custom to just file drop. Custom permission is still there. It doesn't change to file drop (when inside the customize link view).

This can probably be closed. But the customize link part needs to eb a bit clearer

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Sep 15, 2023 •
edited

So the actual issue here is that, when moving from custom permissions, File drop cannot be selected. When clicked the highlight with a grey/ash shows that the selection is active/focused but when actually selected the highlight color is skyblue blue. The select does not happen unless one is coming from a different permission which is not custom.

Clicked Registered Click not registered
Screenshot from 2023-09-15 11-24-59 Screenshot from 2023-09-15 11-25-16

@Fenn-CS Fenn-CS added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2023
Fenn-CS added a commit that referenced this issue Sep 15, 2023
@Fenn-CS
Correctly switch/revert from custom to bundled perms
3b43135 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS mentioned this issue Sep 15, 2023
Merged
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Sep 15, 2023

Thanks for providing more information @small1 a ticket to fix this inconvenience is now on its way and it should disappear in the next release :)

Fenn-CS added a commit that referenced this issue Sep 15, 2023
@Fenn-CS
Correctly switch/revert from custom to bundled perms
f812aab 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS added a commit that referenced this issue Sep 15, 2023
@Fenn-CS
Correctly switch/revert from custom to bundled perms
386b08d 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
blizzz pushed a commit that referenced this issue Sep 15, 2023
@Fenn-CS @blizzz
Correctly switch/revert from custom to bundled perms
de500d1 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Sep 15, 2023
@Fenn-CS @nextcloud-command
Correctly switch/revert from custom to bundled perms
481f5bb 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
zak39 pushed a commit to arawa/server that referenced this issue Oct 11, 2023
@Fenn-CS @zak39
Correctly switch/revert from custom to bundled perms
e5ac52b 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : nextcloud#40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
@Fenn-CS @zak39
Correctly switch/revert from custom to bundled perms
35d43b9 
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : nextcloud#40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug feature: sharing regression
Projects
None yet
Milestone
Nextcloud 27.1.0
Development

Successfully merging a pull request may close this issue.

Correctly switch/revert from custom to bundled perms nextcloud/server
4 participants
@small1 @enoch85 @Fenn-CS @szaimen