Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly switch/revert from custom to bundled perms #40434

Merged
merged 1 commit into from Sep 15, 2023

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Sep 15, 2023

We have a set custom permissions checkbox, that when selected should set the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default, bundledPermissions.ALL but also users can switch from custom permissions to bundled by just changing the radio select, hence we need a mechanism to set the permissions back to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is revertSharingPermission and this commit, makes sure revert values are correctly set upon toggle.

Resolves : #40431

@Fenn-CS Fenn-CS added 3. to review Waiting for reviews 27-feedback labels Sep 15, 2023
@Fenn-CS Fenn-CS added this to the Nextcloud 27.1.1 milestone Sep 15, 2023
@Fenn-CS Fenn-CS force-pushed the 40431-correctly-switch-permissions-radios branch from 3b43135 to f812aab Compare September 15, 2023 11:13
We have a set custom permissions checkbox, that when selected should set
the quick permissions settings to custom as well as show the custom permission settings.

When the checkbox is unchecked the quick permissions have to be reset to the default,
`bundledPermissions.ALL` but also users can switch from custom permissions to `bundled`
by just changing the radio select, hence we need a mechanism to set the permissions back
to the correct fallback depending on where the user has toggled the the custom permission from.

The mechanism is `revertSharingPermission` and this commit, makes sure revert values are correctly
set upon toggle.

Resolves : #40431

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the 40431-correctly-switch-permissions-radios branch from f812aab to 386b08d Compare September 15, 2023 11:14
@blizzz blizzz mentioned this pull request Sep 15, 2023
@blizzz blizzz modified the milestones: Nextcloud 27.1.0, Nextcloud 28 Sep 15, 2023
@blizzz blizzz merged commit d32e03d into master Sep 15, 2023
38 of 39 checks passed
@delete-merged-branch delete-merged-branch bot deleted the 40431-correctly-switch-permissions-radios branch September 15, 2023 13:12
@blizzz
Copy link
Member

blizzz commented Sep 15, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 27-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug 27.1 RC3]: File drop shows all files per default
6 participants