Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log-in page fonts/logo design #4585

Closed
2 of 3 tasks
MariusBluem opened this issue Apr 28, 2017 · 9 comments
Closed
2 of 3 tasks

Log-in page fonts/logo design #4585

MariusBluem opened this issue Apr 28, 2017 · 9 comments
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high papercut Annoying recurring issue with possibly simple fix. regression

Comments

@MariusBluem
Copy link
Member

MariusBluem commented Apr 28, 2017

current master:
bildschirmfoto 2017-04-28 um 21 37 09

latest stable11:
bildschirmfoto 2017-04-28 um 21 38 40

@jancborchardt @nextcloud/designers

@MariusBluem MariusBluem added 1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. regression labels Apr 28, 2017
@MariusBluem MariusBluem added this to the Nextcloud 12.0 milestone Apr 28, 2017
@MorrisJobke MorrisJobke added the papercut Annoying recurring issue with possibly simple fix. label Apr 28, 2017
@jancborchardt
Copy link
Member

Huh, could this be related to the SCSS switch @skjnldsv?

Do you have any theming active @MariusBluem, or can you pinpoint a commit where this started to happen?

@MariusBluem
Copy link
Member Author

Do you have any theming active @MariusBluem, or can you pinpoint a commit where this started to happen?

The font stuff since quite a while ... did not report it, because I thought you all know 😜 No theming active 🤔

@jancborchardt
Copy link
Member

did not report it, because I thought you all know

Never expect this ;) Especially if there’s no existing issue.

Are you familiar with git bisect? Or do you want to learn it? ;) Finding out which commit caused it would be a great help, as I’m a bit busy today :\

@MorrisJobke
Copy link
Member

@jancborchardt this is likely because the login page only uses the guests.css and some rules in there are in the wrong order. We tried to get everything in them at was on the page before but it seems something didn't made it. A bisect doesn't help that much. Better look into the "why are rules for font style not applied" instead of looking for the commit(which is 99.9% the scss one and reverting that is out of scope)

@MariusBluem
Copy link
Member Author

#4694 does fix in in parts ... but the instance name (per default: "Nextcloud") is still not bold 😕 @rullzer

@MorrisJobke
Copy link
Member

For me this is the case 😕

@MorrisJobke MorrisJobke self-assigned this May 11, 2017
@MorrisJobke MorrisJobke removed their assignment May 15, 2017
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels May 15, 2017
@MorrisJobke
Copy link
Member

Old vs new:

bildschirmfoto 2017-05-14 um 22 30 27

bildschirmfoto 2017-05-14 um 22 30 38

@MorrisJobke
Copy link
Member

Instance Name should be bold, slogan normal

Fix is in #4866

@jancborchardt
Copy link
Member

Nextcloud logo too big

Fix is at #4910, please review @juliushaertl @MorrisJobke @MariusBluem :)

LukasReschke added a commit that referenced this issue May 19, 2017
Fix logo being too big on log in page, fix #4585
juliushaertl pushed a commit that referenced this issue May 19, 2017
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high papercut Annoying recurring issue with possibly simple fix. regression
Projects
None yet
Development

No branches or pull requests

3 participants