Fix logo being too big on log in page, fix #4585 #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl and @MorrisJobke to be potential reviewers. |
3 tasks
MorrisJobke
requested changes
May 16, 2017
MorrisJobke
added
2. developing
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Codecov Report
@@ Coverage Diff @@
## master #4910 +/- ##
============================================
+ Coverage 54.16% 54.16% +<.01%
Complexity 22173 22173
============================================
Files 1365 1365
Lines 84893 84885 -8
Branches 1322 1322
============================================
Hits 45981 45981
+ Misses 38912 38904 -8
|
|
@jancborchardt I've added another commit to keep the logo stretched to the container when custom themed logos are used. @MorrisJobke Was that what you were talking about above? Or is it a different issue? |
Yes - works now. |
MorrisJobke
added
3. to review
LukasReschke
approved these changes
May 19, 2017
|
@jancborchardt If you want this backported then please open a backport for stable12. Note that it likely will only be included with Nextcloud 12.0.1. |
|
I think we should backport this. PR at #4976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @nextcloud/designers @MorrisJobke @MariusBluem @juliushaertl – it was caused by theming changes. Removing them makes theming still work, and fixes the issue with the logos being way too big, for example even touching the .warning box on error pages.
Before / after:
