Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impersonate dropdown-option in user management not working anymore #8401

Closed
nickvergessen opened this issue Feb 16, 2018 · 2 comments
Closed
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug
Milestone

Comments

@nickvergessen
Copy link
Member

The last PR that broke/overwrote the action is from @juliushaertl #7790

I can work around this with changing: settings/js/users/users.js

$userListBody.on('click', '.toggleUserActions', function (event) {

to

$userListBody.on('click', '.toggleUserActions > .action', function (event) {

Then there is one from @danxuliu #7668
Which I can "fix" by removing the code block for closing
$(document).on('mouseup', function () {

I need help here. can someone fix this properly, so that https://github.com/nextcloud/impersonate/blob/45e1d490c92270a7f9d452cf3d8966b5f0bef32c/js/impersonate.js#L23 is triggered again?
(please change as little as possible in the impersonate.js because I have that revamped locally already)

@nickvergessen nickvergessen modified the milestone: Nextcloud 14 Feb 16, 2018
@nickvergessen nickvergessen added bug 1. to develop Accepted and waiting to be taken care of backport-request labels Feb 16, 2018
@juliushaertl
Copy link
Member

You should be able workaround this in the impersonate app by using $('#userlist tbody').on('click', '.impersonate', function() { which will then work since the click event in bound after the $userListBody.on('click', '.toggleUserActions' and therefore executed before that.

I'll have a more detailed look tomorrow, to see if we can add a proper fix to the server, so that event propagation will not be stopped there.

@MorrisJobke
Copy link
Member

Fixed by #8416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug
Projects
None yet
Development

No branches or pull requests

4 participants