Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sharing permissions for folders #8479

Closed
jancborchardt opened this issue Feb 21, 2018 · 23 comments
Closed

Simplify sharing permissions for folders #8479

jancborchardt opened this issue Feb 21, 2018 · 23 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish client: 💻 desktop client: 🤖🍏 mobile design Design, UI, UX, etc. enhancement feature: sharing

Comments

@jancborchardt
Copy link
Member

We currently have:

  • Can reshare
  • Can add
  • Can edit
  • Can delete

Now "can delete" does not really make much sense. If you can edit, you can delete all content of a file.

"Can add": We added this cause we originally had CRUD permissions, but do we really need it / do people use it? Usually you can either edit or not.

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Design, UI, UX, etc. feature: sharing labels Feb 21, 2018
@MorrisJobke
Copy link
Member

"Can add": We added this cause we originally had CRUD permissions, but do we really need it / do people use it? Usually you can either edit or not.

I think "can add" is used for the files drop stuff, isn't it? cc @nextcloud/sharing

@rullzer
Copy link
Member

rullzer commented Feb 27, 2018

Yes it is. But as long as wel keep the files drop as a separte option users don't have to care ;)

@MorrisJobke
Copy link
Member

MorrisJobke commented Feb 27, 2018

I still think that we can slim it down to:

  • for internal/federated/circle shares:
  • can edit
  • can reshare
  • for public links
  • can edit
  • files drop (can add without listing files)

@MorrisJobke

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 26, 2018
@jancborchardt

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 5, 2020

@jancborchardt so, do we really want this or not in the end?

@trommegutten
Copy link

trommegutten commented May 21, 2020

Hi, I'm trying to make a share link. If someone have the link, they should be able to see the folder content and upload files, but not be able to delete/edit the files. From the thread it seems like this is something you have removed from the code? Why? :)
Best regards

@jancborchardt
Copy link
Member Author

@jancborchardt so, do we really want this or not in the end?

It’s @rullzer’s call I’d say.

@trommegutten
Copy link

I don't like accidents like this #6620 (comment)

@pixelipo got some thumbs up for this suggestion:

What about simply having 3 independent (checkbox) items:
view (read)
upload
edit/delete

#6620 (comment)

That could be a nice way to do it, what do You think?

@marvinjuette
Copy link

marvinjuette commented Sep 19, 2020

Hey, I am facing the same problem. And if I am correct the problem is only a front-end one because as others already pointed out one can simply change the permission to 5 in the database.

Linkt to post that shows working solution

So basically it should be easy to "add" (display) this option.

But the question is how we want to display that option?

Should it be a checkbox "disable delete" or just another radio button like "upload + read only"?

@Mannshoch
Copy link

I don't like accidents like this #6620 (comment)

@pixelipo got some thumbs up for this suggestion:

What about simply having 3 independent (checkbox) items:
view (read)
upload
edit/delete

#6620 (comment)

That could be a nice way to do it, what do You think?

I personally vote for #10012

@marvinjuette
Copy link

I like the options you get offered when sharing internally. Why don't use them for public link sharing?

@pred2k
Copy link

pred2k commented Jan 31, 2021

I think is this THE use case for a file exchange tool like nextcloud.
We have an event and attendees want to share photo or something else. They probably dont want/need an account. Host dont have all their email addreses.
They can easily upload items via webui, but are not allowed to to delete everything.

Please offer public link sharing setting "upload + read only"!

@kaiserls
Copy link

Dear everyone,
I would like to point out that this issue is linked to many issues which seem to be important to the nextcloud community and some of them are nearly 3 or even 4 years old (#6620, #8479). Couldn't the "upload + read only" feature get decoupled from the complete overhaul of the sharing gui and therefore be quickly published?

@kaiserls
Copy link

kaiserls commented Aug 30, 2021

Is this: #28635 the rework of the sharing permissions #26691 and completely ignoring issue #6620 and all the duplicates? Or am I wrong? Sry if this is the case.

@kongomongo
Copy link

kongomongo commented Feb 10, 2022

I have skimmed through many of those issues like @kaiserls wrote, but I have yet to see any objection to the "upload and not delete" and/or finer-grain control of the https://github.com/nextcloud/server/blob/master/lib/public/Constants.php permissions.

What is the root cause for no progress?

@skjnldsv
Copy link
Member

Done no? @artonge @jancborchardt

@sweenu
Copy link

sweenu commented Jan 19, 2024

If you close this issue, please re-open #6620 because it was closed as duplicate of this issue even though it definitely does not seem to be fixed: we still don't have a way to have File Upload + Read on a folder.

@skjnldsv
Copy link
Member

skjnldsv commented Jan 20, 2024

we still don't have a way to have File Upload + Read on a folder.

Hmm, yes you can? (NC 27 and 28) :)
image

@sweenu
Copy link

sweenu commented Jan 20, 2024

Oh great news! I had tried on the android app, assuming permissions would be the same on every platforms. But indeed, I should have tried on the web before commenting 👍🏽 Great job.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish client: 💻 desktop client: 🤖🍏 mobile design Design, UI, UX, etc. enhancement feature: sharing
Projects
None yet
Development

No branches or pull requests