Fix new group selection #10045
Merged
Fix new group selection #10045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
rullzer,
MorrisJobke,
icewind1991 and
juliushaertl
juliushaertl
approved these changes
Jun 29, 2018
icewind1991
approved these changes
Jun 29, 2018
|
conflicts! |
|
Let me fix them. |
Thanks, I'm working on another pr, can't do right now :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
MorrisJobke
force-pushed
the
groups-creation-fixes
branch
from
759b24c
to
b495716
Compare
MorrisJobke
added
4. to release
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes selection of a freshly created group
Since #9919
The checks for canAdd or canRemove were too wide and preventing a freshly created group to have the proper permissions to be added to a user.
A refresh solved the issue.