Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quick-Access to favorite folder in left sidepanel in files-app (Cleanup) #10246

Closed
wants to merge 78 commits into from
Closed

Add Quick-Access to favorite folder in left sidepanel in files-app (Cleanup) #10246

wants to merge 78 commits into from

Conversation

newhinton
Copy link
Contributor

@newhinton newhinton commented Jul 15, 2018 •
edited
Loading

See #9714
See #9720
See #10176
@skjnldsv

fnuesse and others added 30 commits June 1, 2018 20:29
Added FavoritesQuickaccess-Sidebar
e86df3b
Added FavoritesQuickaccess-Sidebar
c484744
Added Files-FavoritesQuickaccess-Toggle
055243a
Fixed CSS for SpacerElement
b563db1
Removed Unnessessary Alerts and added Translations
32651d4
Tried fixing initial Quick-Access Checkboxstate
994a1c2
Tried fixing initial Quick-Access Checkboxstate
1fadbd3 
Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>
Merge remote-tracking branch 'origin/master'
e347f77
Changed double-Quotes to single-Quotes
c1a8e81
Revert webdavurl which was changed by mistake
749fd5f
Revert quota-icon which was changed by mistake
cabd514
Changed the Folderhandling from custom-designed to nextcloud-Navigati…
81e651d 
…onManager-handling

Signed-off-by: fnuesse <fnuesse@techfak.uni-bielefeld.de>
@newhinton
Moved CSS-Spacerclass to apps.scss for global usage
c0ef6fc 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Renamed settings-caption in apps.scss to app-navigation-caption
ac98314 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed old input-tag for showQuickAccess-state
6588bbe 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed old spacer element in files.scss
dbc72cd 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Changed style of favorites-sublist and disabled the ability to disabl…
675d0ac 
…e files-quickaccess

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added toggleable QuickAccess
7e42f12 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Deleted wrongly commited File
cf8a527 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added quickaccess-state persistence
1d0ec1b 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Started implementing sorting-algorithm for proper alphabetical display
3a731e1 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Finished Sorting of Quickaccess elements
c6f0749 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Implemented persistence for reverse-list and sorting-strategy
245e1c0 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Implemented initial sorting for reverse-list and sorting-strategy
69f52fa 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
9a07345 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
916fbd7 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
deb2049 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed complete app-breakdown if no favorites are set
1f57988 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Hid three-dot menu if no favorites are selected
7596d02 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added responsive folderadding
cc41b9f 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added custom order sorting option to quickaccess
24c2209 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added fallback for custom ordering
63ce668 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Set Quickaccess-ordering to custom order
2cfae6f 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fix collapsible-Button when list was emptied (or got first element)
c7a4bed 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Bad url-generation in javascript for new quickaccessitems
0ac7134 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed vertical scrolling in sortable-list which leads to "hidden" navbar
8b3dbba 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed unnessessary console logs
7131707 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Bounds in custom sorting
6059ec9 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Reformatted code
c38af2c 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed horizontalscroll on sortable-list
b7fe0be 
Fixed "stuck element" where you could not switch back to the original ordering in the sortable-list

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added drop-animation to sortable-list
c395b8c 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Added icon-change on drag
8b9a6cb 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed Navbar-closing in app when favorites-list is toggled on mobile
80031f7 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Refactored Code
daefeb5 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Changed to alphabetical sorting
e79f749 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed deletion of folder with identical names
9809a7e 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed ability to add files to the quickaccess
3721228 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Fixed wrong path-generation when added from favorites-star
c2fb31d 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Removed Element from navbar when favorite-star in detailview is toggl…
abec4ea 
…ed off

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
Merge remote-tracking branch 'origin/master'
d6ea2c1
@newhinton
forkupdate from nextcloud/server
cd8bda3 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@newhinton
removed sorting code from files app
d9d6285 
Signed-off-by: fnuesse <felix.nuesse@t-online.de>
@rullzer rullzer requested a review from skjnldsv July 20, 2018 10:17
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 20, 2018
@rullzer
Copy link
Member

rullzer commented Jul 20, 2018

@newhinton cool stuff thanks.

But this has a ton of conflicts. Also a ton of commits.

Could I ask you to rebase on current master.
Also you can create branches in the main server repo so other people can more easily work on your branch as well :)

THNX.

@newhinton
Copy link
Contributor Author

@rullzer Yes i have already seen that my forkupdate didn't work out as expected ;) I'll redo my latest PR's, tomorrow

@newhinton newhinton mentioned this pull request Jul 20, 2018
Merged
@newhinton
Copy link
Contributor Author

newhinton commented Jul 20, 2018 •
edited
Loading

Old, since #10320 does the same and is better

@newhinton newhinton closed this Jul 20, 2018
@jospoortvliet
Copy link
Member

@newhinton you coming to https://nextcloud.com/conf ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@newhinton @rullzer @jospoortvliet