Add Quick-Access to favorite folder in left sidepanel in files-app #9720

newhinton · 2018-06-02T19:08:40Z

I have implemented the feature request from Issue #9714.
Fixes #9714

The only thing which does not properly work, is the initial State of the checkbox which enables this functionality. It is properly set, but the initial state is always unchecked, regardless of the true value.

codecov · 2018-06-03T08:48:07Z

Codecov Report

Merging #9720 into master will decrease coverage by 49.67%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #9720       +/-   ##
============================================
- Coverage     51.72%   2.04%   -49.68%     
- Complexity    25733   26007      +274     
============================================
  Files          1636    1585       -51     
  Lines         96030   88848     -7182     
  Branches       1384       0     -1384     
============================================
- Hits          49667    1815    -47852     
- Misses        46363   87033    +40670

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Controller/ApiController.php	`0% <0%> (-50%)`	`32 <9> (+9)`
apps/files/lib/Controller/ViewController.php	`0% <0%> (-78.34%)`	`23 <1> (+5)`
apps/files/appinfo/routes.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
apps/files/templates/appnavigation.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
lib/private/NavigationManager.php	`0% <0%> (-77.56%)`	`61 <9> (+9)`
lib/private/App/CompareVersion.php	`0% <0%> (-100%)`	`8% <0%> (ø)`
lib/private/Security/Certificate.php	`0% <0%> (-100%)`	`16% <0%> (ø)`
lib/private/Files/ObjectStore/Mapper.php	`0% <0%> (-100%)`	`2% <0%> (ø)`
lib/private/Security/IdentityProof/Key.php	`0% <0%> (-100%)`	`3% <0%> (ø)`
lib/private/Memcache/ArrayCache.php	`0% <0%> (-100%)`	`17% <0%> (ø)`
... and 1009 more

skjnldsv

Hello! Thanks for your pull request and welcome! :) 🎉

I added quite a few comments to explain some of the required changes :)
Feel free to ask for more details if I did not explained properly ;)

skjnldsv · 2018-06-03T16:56:11Z

apps/files/templates/appnavigation.php

 		<?php } ?>
+
+
+		<?php if($_['favoritesFolders']>0){


This should not be created. All navigation elements should go into the navigationItems. Otherwise this goes against the simple implementation we did here. We should not add multiple types of navigations items.

This will also break the pinned system if another app decide to add one new in the nav item list.
If you did that just to add your spacer, please create a new condition in the main loop and a check to detect the use of a spacer item :)

skjnldsv · 2018-06-03T17:01:23Z

apps/files/css/files.scss

@@ -106,6 +106,19 @@
 	background-image: url('../img/delete.svg?v=1');
 }

+.nav-sidebar-spacer {


This should be standardise an put into the apps.scss file.

Please cut the code of the settings-caption class and put it into the apps.scss file (change the class name to something like app-navigation-caption

Update the uses of the old settings-caption across the server https://github.com/nextcloud/server/search?utf8=✓&q=settings-caption to you new class name

use the same class for your Favorites navigation element

Like so any other app that also register a spacer within the files app (from anywhere like their own application or from another nextcloud app) won't have anything to edit in the server core code :)

skjnldsv · 2018-06-03T17:02:16Z

apps/files/lib/Controller/ViewController.php

+
+		$helper= new \OCA\Files\Activity\Helper($tagger);
+		$favElements = $helper->getFavoriteFilePaths($this->userSession->getUser()->getUID());
+		$favItems = $favElements["items"];


single quotes please ;)

skjnldsv · 2018-06-03T17:02:22Z

apps/files/lib/Controller/ViewController.php

+		$favElements = $helper->getFavoriteFilePaths($this->userSession->getUser()->getUID());
+		$favItems = $favElements["items"];
+
+		$key="show_Quick_Access";


skjnldsv · 2018-06-03T17:02:31Z

apps/files/lib/Controller/ViewController.php

+		}
+
+		$i=0;
+		foreach($favElements["folders"] as $elem){


skjnldsv · 2018-06-03T17:02:43Z

apps/files/lib/Controller/ViewController.php

+		if($showFavoriteQuickAccess){
+			$nav->assign('favoritesItems', $favItems);
+			$nav->assign('favoritesFolders', $favFolder);
+			$nav->assign('setQuickAccessChecked', "checked");


skjnldsv · 2018-06-03T17:03:28Z

apps/files/templates/appnavigation.php

-	<?php $pinned = 0 ?>
+		<?php
+		$pinned = 0;
+		$trashelement = null;


See other comment, we don't need to create specific entries for the trashbin, this should stay clean.

skjnldsv · 2018-06-03T17:04:12Z

apps/files/templates/appnavigation.php

 		} ?>">
-			<a href="#" class="icon-quota svg">
+			<a href="#" class="nav-icon-quota svg">


I'm not sure the nav-icon-quota class exists? 🤔

skjnldsv · 2018-06-03T17:05:02Z

apps/files/templates/appnavigation.php

 			<label for="webdavurl"><?php p($l->t('WebDAV'));?></label>
-			<input id="webdavurl" type="text" readonly="readonly" value="<?php p($_['webdavurl']); ?>" />
+			<input id="webdavurl" type="text" readonly="readonly" value="<?php p(\OCP\Util::linkToRemote('webdav')); ?>" />


Why this change? Was it not working? (I did not checked) :)

newhinton · 2018-06-03T17:51:35Z

@skjnldsv The quotes and the webdav/quota-changes are fixed, they were made by mistake, thanks for pointing out!
What do you mean with "put the css in app.scss"? Aren't they?
Or do you mean that the name of my style is misleading and should be changed to something more descriptive?

The other changes will need some time since they are not quick fixes.

skjnldsv · 2018-06-03T18:03:32Z

What do you mean with "put the css in app.scss"? Aren't they?
Or do you mean that the name of my style is misleading and should be changed to something more descriptive?

Sorry, I should have been more clear :)
The /core/css/apps.scss file contains the design standards across all of our apps and core. That includes (but not limited to) the app navigation, the app settings, the popoverenus, the app-content-lists... etc. Since we already have a design for the spacer (see the settings section of nextcloud and my screenshot) we should use this design but make it available for everyone in the future. So move the settings-caption property into the app-navigation part of the apps.scss file and rename it to a class that fit the class name pattern we use (lile app-navigation-caption for example :) )

server/settings/css/settings.scss

Lines 1244 to 1257 in 760b28b

    
           .settings-caption { 
        
           	font-weight: bold; 
        
           	line-height: 44px; 
        
           	padding: 0 44px; 
        
           	white-space: nowrap; 
        
           	text-overflow: ellipsis; 
        
           	// !important to overwrite specific hover and focus 
        
           	opacity: .4 !important; 
        
           	box-shadow: none !important; 
        
           	&:not(:first-child) { 
        
           		margin-top: 22px; 
        
           	} 
        
           }

Therefore, since your pull request will most likely be integrated into 14, every app that want to add a caption-like design into their navigation will be able to use our design thanks to you 😉

skjnldsv · 2018-06-03T18:11:39Z

The other changes will need some time since they are not quick fixes.

It shouldn't be that much, don't worry. Since we already have the code to add items to the app navigation, just make your script add the favorites items with the \OCA\Files\App::getNavigationManager()->add() function and the spacer with the same way.

You may need to edit the add function to add a new property like type to differentiate the 'traditional' navigation sitems from the spacers ;)

skjnldsv · 2018-06-07T07:45:25Z

core/css/apps.scss

@@ -561,6 +561,25 @@ kbd {
 	.app-navigation-entry-menu ul {
 		list-style-type: none;
 	}
+
+	.settings-caption {


app-navigation-caption would be better please :)

newhinton · 2018-06-07T07:50:49Z

Yeah, you are right about the css-style-name, forgot to change its name after getting it to work :D

But there is still a last todo on my list, the Checkbutton wich enables this functionality for the user is not properly set on page load. It works and sets the correct value in the backend, but the current state is not applied on page load. Where do i need to set this value initially?

skjnldsv · 2018-06-07T08:01:32Z

apps/files/templates/appnavigation.php

@@ -40,9 +42,14 @@ class="nav-icon-<?php p($item['icon'] !== '' ? $item['icon'] : $item['id']) ?> s
 				<input class="checkbox" id="showhiddenfilesToggle" checked="checked" type="checkbox">
 				<label for="showhiddenfilesToggle"><?php p($l->t('Show hidden files')); ?></label>
 			</div>
+			<div id="files-setting-showFavoriteQuickAccess">
+				<input class="checkbox" id="showfavoritequickaccessToggle" checked="checked" type="checkbox">


But there is still a last todo on my list, the Checkbutton wich enables this functionality for the user is not properly set on page load. It works and sets the correct value in the backend, but the current state is not applied on page load. Where do i need to set this value initially?

The status is always checked by default here.
Either you set the state on javascript on load (not quite fond of this), or you pass it via php using the getUserValue config check (Better solution I think)

This is looking great by the way! 😉

Yes, but the checked="checked" does not change the state. It is always disabled by default, and i think it is set by javascript to unchecked. I have tried to mimic the behaviour of the showHiddenFiles-Toggle, but it does not seem to work. I don't now enough about the internal workings of the core, so i'm stuck here

And thank you for the compliment ;)

You can check the source code to see if php is properly setting this up.
But like Jan said, don't bother with the settings, remove it, it will be easier :)

And it's a great addition, so I guess less work from you and more pleasure for the users ;)

jancborchardt · 2018-06-07T09:47:49Z

Good stuff! See my design comments in the issue at #9714 :)

skjnldsv · 2018-06-07T17:22:54Z

core/css/apps.scss

+		pointer-events:none;
+	}
+
+	.app-navigation-subelement {


Okay, I get it now! :)
There is already a standard for this:
Look at our documentation : https://docs.nextcloud.com/server/13/developer_manual/design/navigation.html

skjnldsv

Amazing work! Let's review this :)

The Favourite first item menu is not collapsible, this should be possible
The three-dot-more-icon should be hidden until the user have at least one directory favourited
The list is not updated in real time

That's all I found so far :)
Thanks a lot!

newhinton · 2018-06-18T07:28:21Z

What do you mean with "The Favourite first item menu"?

skjnldsv · 2018-06-18T08:10:16Z

What do you mean with "The Favourite first item menu"?

I mean the top level menu. The entry that says "Favorites" :)
https://docs.nextcloud.com/server/13/developer_manual/design/navigation.html#collapsible-entry

newhinton · 2018-06-18T08:26:17Z

@skjnldsv Where do i find the method which marks a file as a favorite? To make this thing "responsive", i need to add a function there, which adds or removes the item from the list. I cant seem to find this method, any hint?

skjnldsv · 2018-06-18T08:32:02Z

@newhinton Sure :)

server/apps/files/js/tagsplugin.js

Lines 89 to 160 in f347e2e

    
           fileActions.registerAction({ 
        
           	name: 'Favorite', 
        
           	displayName: function(context) { 
        
           		var $file = context.$file; 
        
           		var isFavorite = $file.data('favorite') === true; 
        
           		if (isFavorite) { 
        
           			return t('files', 'Remove from favorites'); 
        
           		} 
        
           		// As it is currently not possible to provide a context for 
        
           		// the i18n strings "Add to favorites" was used instead of 
        
           		// "Favorite" to remove the ambiguity between verb and noun 
        
           		// when it is translated. 
        
           		return t('files', 'Add to favorites'); 
        
           	}, 
        
           	mime: 'all', 
        
           	order: -100, 
        
           	permissions: OC.PERMISSION_NONE, 
        
           	iconClass: function(fileName, context) { 
        
           		var $file = context.$file; 
        
           		var isFavorite = $file.data('favorite') === true; 
        
           		if (isFavorite) { 
        
           			return 'icon-star-dark'; 
        
           		} 
        
           		return 'icon-starred'; 
        
           	}, 
        
           	actionHandler: function(fileName, context) { 
        
           		var $favoriteMarkEl = context.$file.find('.favorite-mark'); 
        
           		var $file = context.$file; 
        
           		var fileInfo = context.fileList.files[$file.index()]; 
        
           		var dir = context.dir || context.fileList.getCurrentDirectory(); 
        
           		var tags = $file.attr('data-tags'); 
        
           		if (_.isUndefined(tags)) { 
        
           			tags = ''; 
        
           		} 
        
           		tags = tags.split('|'); 
        
           		tags = _.without(tags, ''); 
        
           		var isFavorite = tags.indexOf(OC.TAG_FAVORITE) >= 0; 
        
           		if (isFavorite) { 
        
           			// remove tag from list 
        
           			tags = _.without(tags, OC.TAG_FAVORITE); 
        
           		} else { 
        
           			tags.push(OC.TAG_FAVORITE); 
        
           		} 
        
           		// pre-toggle the star 
        
           		toggleStar($favoriteMarkEl, !isFavorite); 
        
           		context.fileInfoModel.trigger('busy', context.fileInfoModel, true); 
        
           		self.applyFileTags( 
        
           			dir + '/' + fileName, 
        
           			tags, 
        
           			$favoriteMarkEl, 
        
           			isFavorite 
        
           		).then(function(result) { 
        
           			context.fileInfoModel.trigger('busy', context.fileInfoModel, false); 
        
           			// response from server should contain updated tags 
        
           			var newTags = result.tags; 
        
           			if (_.isUndefined(newTags)) { 
        
           				newTags = tags; 
        
           			} 
        
           			context.fileInfoModel.set({ 
        
           				'tags': newTags, 
        
           				'favorite': !isFavorite 
        
           			}); 
        
           		}); 
        
           	} 
        
           });

skjnldsv · 2018-06-18T10:37:11Z

apps/files/js/navigation.js

-				var dotmenu = document.getElementById("quickaccess-list");
-				dotmenu.style.display='';
+
+				if(!$("#favorites-toggle" ).hasClass('open')){


toggleClass
https://api.jquery.com/toggleClass/

newhinton · 2018-06-18T10:43:28Z

@skjnldsv check it out now, it should be pretty finished now

skjnldsv

Beautiful! :)

newhinton · 2018-07-03T14:41:16Z

The default would be dateadded, which would be the good first step you mentioned. We have already passed that after introducing sorting in any way.

The difference in code to maintain is not really that big, counted ~65 Lines of code more in the custom order, which includes brackets and so on.

Last Date modified will NOT always show relevant stuff, since a cloud is often a shared medium (shared by bots which sync stuff, friends moving files in your shared folders, etc.). This will often result in an order which is not understandable by the user. It is unclear why it changed, since there is no explanation how it sorts.

We dont need to make it discoverable, if the user never detects it, he can just use last date added, which does not have the ability to change randomly.

A user could drag a folder into another folder, which could have WAY more serious consequences (synced folders, dataleak in shared folders, etc). I do not consider accidential dragging of elements which pose no risk at all (except from a messed up sorting, which can be solved by dragging it back)

And as i stated earlier, dragging on mobile is not possible. You simply cannot drag on mobile browsers, if you do not implement it specifically.

You dont need a default, because it's a custom order.

From a feature-based standpoint, i consider this feature ready. I have implemented what i intended to achieve here, which will add benefit to users if they decide to use it. I do not consider "lastdatemodified" as a good design choice, since it introduces intransparency and confusion to a less savy user. Also it limits the benefits since you would always need to find your folders again.

As long as there are no technical problems, bugs or nessessary codestylechanges, i consider the work finished, and i will not change the sorting since then i would have developed a feature which i would never use.
I have explained how you can change the sorting-order, if you really wish to change it, please do it yourself.

skjnldsv

Adding a file to favorite create a new entry in the left menu with the folder icon despite the fact that the starred file is not a directory
On the favorite menu, when opening a folder details sidebar, clicking the star keeps adding entries to the menu and do not remove the directory from the favourites

newhinton · 2018-07-05T12:24:31Z

@jancborchardt It should be noted that my comment is only valid for lastdatemodified sorting. If you really think custom sorting is over the top (which i disagree), we could settle by sorting it alphabetically, which would not add a changing ui element. This would be the next sensible thing to do.

@skjnldsv Thanks for pointing this out, i'll fix it!

newhinton · 2018-07-05T13:59:50Z

@jancborchardt What about a dropdown menu? I know, its still a setting more in the ui, its still a little bit more to maintain, but i'm trying to make it work for everyone. Also it is a more slender solution to the sorting-problem as the last time. Your thoughts about that?

newhinton · 2018-07-05T16:49:15Z

@skjnldsv I should have fixed the bugs

skjnldsv · 2018-07-06T06:56:02Z

apps/files/templates/appnavigation.php

@@ -17,7 +17,7 @@ class="pinned <?php p($pinned === 0 ? 'first-pinned ' : '') ?><?php
 			<a href="#" class="icon-quota svg">
 				<p id="quotatext"><?php
 					if ($_['quota'] !== \OCP\Files\FileInfo::SPACE_UNLIMITED) {
-						p($l->t('%s of %s used', [$_['usage'], $_['total_space']]));
+						p($l->t('%s of %s', [$_['usage'], $_['total_space']]));


Ah no! Do it in another pr please :)
Otherwise it's confusing!

Small missunderstanding ;)

skjnldsv

Ok from me.
Please rebase to master.

Only downside is that clicking a favourited folder change the whole page instead of loading the folder only. But we can fix this in a later pr.

skjnldsv · 2018-07-10T10:46:54Z

Sigh... new pr is here: #10176 😞

Add Quick-Access to favorite folder in left sidepanel in files-app #9720

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

…leanup Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Andreas-Kainz · 2019-12-30T10:01:56Z

How can I pin an folder to the left sidebar?

newhinton · 2019-12-30T10:04:58Z

@DarkknightAK
What do you mean?
if you want to use the quickaccess list, you can simply mark a folder as a favorite, that adds the folder there

Andreas-Kainz · 2019-12-30T10:09:57Z

I'm thinking more on something like you know from any file manager where you can pin folders to the sidebar.

and with folders I also mean labels. so you can show in addition to the predefined stuff in the sidebar stuff that was pinned by the user.

Andreas-Kainz · 2019-12-30T10:12:21Z

Cause now you have 5 predefined items in the sidebar and you need two clicks (favorites -> folder) you come to your favorite folders. For tags you need three clicks (Tags drop down tag search and than have the results to click)

newhinton · 2019-12-30T10:14:14Z

Ah okay

that is not possible at the moment. The only way to add a folder to the sidebar is to mark it as a favorite

however, you can expand the favorites in the sidebar, this will allow you to get to a folder quickly. it should stay expanded over sessions

Andreas-Kainz · 2019-12-30T10:17:14Z

Ah cool that's fine to me. Thanks.

would it be also possible to pin labels that way to have an expand at labels and have there the labels.

newhinton · 2019-12-30T10:20:24Z

Probably yes, but it needs to be developed and accepted. Also since this pr is already closed, could you open a new issue for that?

Andreas-Kainz · 2019-12-30T10:30:31Z

#18607

skjnldsv requested changes Jun 3, 2018

View reviewed changes

skjnldsv added enhancement design Design, UI, UX, etc. 2. developing Work in progress feature: files labels Jun 3, 2018

skjnldsv added this to the Nextcloud 14 milestone Jun 3, 2018

skjnldsv requested a review from jancborchardt June 3, 2018 17:07

skjnldsv reviewed Jun 7, 2018

View reviewed changes

skjnldsv requested changes Jun 7, 2018

View reviewed changes

skjnldsv mentioned this pull request Jun 7, 2018

Add Quick-Access to favorite folder in left sidepanel in files-app #9714

Closed

skjnldsv requested changes Jun 18, 2018

View reviewed changes

skjnldsv reviewed Jun 18, 2018

View reviewed changes

skjnldsv approved these changes Jun 18, 2018

View reviewed changes

skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 18, 2018

skjnldsv requested review from rullzer, MorrisJobke and juliushaertl June 18, 2018 10:50

skjnldsv requested changes Jul 5, 2018

View reviewed changes

skjnldsv reviewed Jul 6, 2018

View reviewed changes

skjnldsv approved these changes Jul 10, 2018

View reviewed changes

skjnldsv requested review from juliushaertl and MorrisJobke July 10, 2018 10:34

skjnldsv closed this Jul 10, 2018

skjnldsv force-pushed the master branch from 8f27a68 to a22bc0e Compare July 10, 2018 10:43

skjnldsv mentioned this pull request Jul 10, 2018

Add Quick-Access to favorite folder in left sidepanel in files-app #9720 #10176

Merged

skjnldsv added a commit that referenced this pull request Jul 12, 2018

Merge pull request #10176 from nextcloud/newhinton/master

052221a

Add Quick-Access to favorite folder in left sidepanel in files-app #9720

newhinton mentioned this pull request Jul 15, 2018

Add Quick-Access to favorite folder in left sidepanel in files-app (Cleanup) #10246

Closed

newhinton added a commit that referenced this pull request Jul 20, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

a6c9727

newhinton mentioned this pull request Jul 20, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720 #10320

Merged

newhinton added a commit that referenced this pull request Jul 24, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

6a36ee0

rullzer pushed a commit that referenced this pull request Jul 24, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

fd61207

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

skjnldsv pushed a commit that referenced this pull request Aug 8, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

7a78e0c

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

skjnldsv added a commit that referenced this pull request Aug 8, 2018

Merge pull request #10320 from nextcloud/feature/10176/Quick-Access-C…

f8e9f86

…leanup Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

weeman1337 pushed a commit that referenced this pull request Aug 9, 2018

Cleanup of leftover-sorting-code from quickaccess-feature #9714 #9720

da69fef

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

Add Quick-Access to favorite folder in left sidepanel in files-app #9720

Add Quick-Access to favorite folder in left sidepanel in files-app #9720

Conversation

newhinton commented Jun 2, 2018 • edited by skjnldsv Loading

codecov bot commented Jun 3, 2018 • edited Loading

Codecov Report

skjnldsv left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

newhinton commented Jun 3, 2018 • edited Loading

skjnldsv commented Jun 3, 2018 • edited Loading

skjnldsv commented Jun 3, 2018

Choose a reason for hiding this comment

newhinton commented Jun 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jancborchardt commented Jun 7, 2018

Choose a reason for hiding this comment

skjnldsv left a comment • edited Loading

Choose a reason for hiding this comment

newhinton commented Jun 18, 2018 • edited Loading

skjnldsv commented Jun 18, 2018 • edited Loading

newhinton commented Jun 18, 2018 • edited Loading

skjnldsv commented Jun 18, 2018 • edited Loading

Choose a reason for hiding this comment

newhinton commented Jun 18, 2018

skjnldsv left a comment

Choose a reason for hiding this comment

newhinton commented Jul 3, 2018

skjnldsv left a comment

Choose a reason for hiding this comment

newhinton commented Jul 5, 2018

newhinton commented Jul 5, 2018

newhinton commented Jul 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skjnldsv left a comment

Choose a reason for hiding this comment

skjnldsv commented Jul 10, 2018

Andreas-Kainz commented Dec 30, 2019

newhinton commented Dec 30, 2019

Andreas-Kainz commented Dec 30, 2019

Andreas-Kainz commented Dec 30, 2019

newhinton commented Dec 30, 2019

Andreas-Kainz commented Dec 30, 2019

newhinton commented Dec 30, 2019

Andreas-Kainz commented Dec 30, 2019

newhinton commented Jun 2, 2018 •

edited by skjnldsv

Loading

codecov bot commented Jun 3, 2018 •

edited

Loading

skjnldsv left a comment •

edited

Loading

newhinton commented Jun 3, 2018 •

edited

Loading

skjnldsv commented Jun 3, 2018 •

edited

Loading

newhinton commented Jun 7, 2018 •

edited

Loading

skjnldsv left a comment •

edited

Loading

newhinton commented Jun 18, 2018 •

edited

Loading

skjnldsv commented Jun 18, 2018 •

edited

Loading

newhinton commented Jun 18, 2018 •

edited

Loading

skjnldsv commented Jun 18, 2018 •

edited

Loading