Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming admin improvements #1049

Merged
merged 2 commits into from
Aug 26, 2016
Merged

Theming admin improvements #1049

merged 2 commits into from
Aug 26, 2016

Conversation

juliushaertl
Copy link
Member

2nd part of #770 split

  • Add preview of login screen
  • Hide undo buttons on default values

requires #1026

@juliushaertl juliushaertl added this to the Nextcloud 11.0 milestone Aug 25, 2016
@juliushaertl
Copy link
Member Author

CI is happy, ready for review @nextcloud/designers @nextcloud/theming

I've included #1026 for easier testing, will rebase to master once this is merged.

@MariusBluem
Copy link
Member

👍

@rullzer
Copy link
Member

rullzer commented Aug 26, 2016

#1026 is in

@juliushaertl
Copy link
Member Author

@rullzer rebase done.

@nickvergessen
Copy link
Member

Works 👍

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2016
@MariusBluem MariusBluem merged commit 5c73596 into master Aug 26, 2016
@MariusBluem MariusBluem deleted the theming-admin-improvements branch August 26, 2016 11:37
@MariusBluem
Copy link
Member

Backport to stable10 would be nice 😁 .. So that we have some more theming improvements up there :) @karlitschek

@nickvergessen
Copy link
Member

Or we give people a reason to update to 11?
The fixes in this branch are not really critical but more like enhancements.

@LukasReschke
Copy link
Member

Agreeing with @nickvergessen on that one.

@jancborchardt
Copy link
Member

Yep, let’s not backport everything please. ;)

@juliushaertl juliushaertl mentioned this pull request Aug 26, 2016
Closed
@MorrisJobke MorrisJobke mentioned this pull request Jan 23, 2017
Closed
@yesiamdollar yesiamdollar mentioned this pull request Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: theming
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juliushaertl @MariusBluem @rullzer @nickvergessen @LukasReschke @jancborchardt