Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reset to default button for theming values on hover #3198

Closed
claell opened this issue Jan 22, 2017 · 7 comments
Closed

Show reset to default button for theming values on hover #3198

claell opened this issue Jan 22, 2017 · 7 comments
Labels
design Design, UI, UX, etc. enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone

Comments

@claell
Copy link

claell commented Jan 22, 2017

When in the Theming section of administration there are "restore to default" options offered when changing the logo or Login image. When changing other theming settings this is not offered.
bildschirmfoto vom 2017-01-22 21-00-20

At least for the color it would make sense to also offer a reset button.

@claell claell changed the title Reset to default option for every setting in theming Reset to default option for more settings in theming Jan 22, 2017
@schiessle
Copy link
Member

schiessle commented Jan 23, 2017

You need to click into the input field to see the undo buttons inline (only if the input field doesn't contain the default value).

cc @nextcloud/designers I think we should show the undo button on hover otherwise it is really hard to discover.

@schiessle schiessle added design Design, UI, UX, etc. enhancement labels Jan 23, 2017
@eppfel
Copy link
Member

eppfel commented Jan 23, 2017

👍 For onHover.
"Always show reset button" was dismissed before (too lazy to search for the discourse), but I am open to it.
@nextcloud/theming

@nickvergessen nickvergessen added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jan 23, 2017
@MorrisJobke
Copy link
Member

too lazy to search for the discourse

#770 and #1049

@claell
Copy link
Author

claell commented Jan 23, 2017

Ah, did not expected it to be in the input field.

From a user perspective I expected a "pattern". All existing reset buttons are placed on the right or on top of the changed element, so I did not search for it in the input field (and maybe it would make sense to have every button at a similar position).

Regardless showing it when hovering over it or always showing it will improve the current situation.

@jancborchardt
Copy link
Member

Yeah, also showing the reset function on hover makes a lot of sense. What do you think @juliushaertl?

@juliushaertl juliushaertl changed the title Reset to default option for more settings in theming Show reset to default button for theming values on hover Jun 6, 2017
@juliushaertl
Copy link
Member

Yeah, also showing the reset function on hover makes a lot of sense.

👍 from my side

jancborchardt added a commit that referenced this issue Jun 9, 2017
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member

Pull request at #5319, please review :)

@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Jun 9, 2017
MorrisJobke added a commit that referenced this issue Jun 12, 2017
Show reset to default button for theming values on hover, fix #3198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UI, UX, etc. enhancement feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

7 participants