Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate key violation in 2FA provider registry DAO #10611

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Fix duplicate key violation in 2FA provider registry DAO #10611

merged 2 commits into from
Aug 9, 2018

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 9, 2018 •
edited
Loading

@ChristophWurst
Add integration/unit test for the double-insert of same values
85bc5ed 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 14 milestone Aug 9, 2018
@ChristophWurst ChristophWurst self-assigned this Aug 9, 2018
@ChristophWurst
Fix double-inserts of the same provider state
8db66d5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 9, 2018
@ChristophWurst
Copy link
Member Author

continuous-integration/drone/pr — the build was successful

🚀

blizzz
blizzz approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rullzer rullzer merged commit 88603e9 into master Aug 9, 2018
@rullzer rullzer deleted the fix/2fa-provider-user-dao-duplicate-key branch August 9, 2018 13:52
@rullzer rullzer mentioned this pull request Aug 9, 2018
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: authentication high
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @rullzer @blizzz