Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14] fix js files client for user names with spaces #11152

Merged
merged 1 commit into from
Sep 11, 2018
Merged

[14] fix js files client for user names with spaces #11152

merged 1 commit into from
Sep 11, 2018

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991
fix js files client for user names with spaces
9b64c27 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 10, 2018
@icewind1991 icewind1991 added this to the Nextcloud 14.0.1 milestone Sep 10, 2018
@icewind1991 icewind1991 mentioned this pull request Sep 10, 2018
Closed
@JSoko
Copy link
Member

JSoko commented Sep 11, 2018

That works for me. Thank You @icewind1991 !

@skjnldsv
Copy link
Member

@JSoko can you add your review up top please :)

@skjnldsv skjnldsv requested a review from JSoko September 11, 2018 06:00
JSoko
JSoko approved these changes Sep 11, 2018
View reviewed changes
Copy link
Member

@JSoko JSoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works on my instance!

@JSoko JSoko added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 11, 2018
@skjnldsv skjnldsv merged commit 5209348 into stable14 Sep 11, 2018
@skjnldsv skjnldsv deleted the davclient-js-decode-14 branch September 11, 2018 08:46
@nickvergessen nickvergessen mentioned this pull request Sep 11, 2018
Merged
@nickvergessen nickvergessen mentioned this pull request Oct 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSoko JSoko JSoko approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 14.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @JSoko @skjnldsv