Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new group entry on users list + fixes #11193

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Add new group entry on users list + fixes #11193

merged 1 commit into from
Sep 28, 2018

Conversation

skjnldsv
Copy link
Member

  • Add a 'nex group' entry on the menu
  • Fix accessibility tab order
  • Fix some design issues
  • Added group creation on the new user group select

Fix #11182

@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Sep 12, 2018
@skjnldsv skjnldsv self-assigned this Sep 12, 2018
@jancborchardt
Copy link
Member

@skjnldsv instead of a separate entry, it might be nicer to just have a "+" icon on the right of the "Groups" header? :)

(Also, could you post a screenshot? Am on vacation atm and only saw this by chance. ;)

@skjnldsv
Copy link
Member Author

@jancborchardt that's what I thought at first. We'll need to modify a bit the server design yes. Let's see what I can do.

@skjnldsv skjnldsv mentioned this pull request Sep 25, 2018
Closed
@blizzz
Copy link
Member

blizzz commented Sep 26, 2018

needs a rebase

MorrisJobke
MorrisJobke approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
Copy link
Member

CI failure unrelated.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 26, 2018
rullzer
rullzer approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@skjnldsv
Add new group entry on users list + fixes
2b41b01 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke MorrisJobke merged commit b7bd6bd into master Sep 28, 2018
@MorrisJobke MorrisJobke deleted the add-group-settings branch September 28, 2018 15:31
@MorrisJobke
Copy link
Member

@skjnldsv Could you backport this to stable14?

This was referenced Oct 3, 2018
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Oct 4, 2018
Closed
@jammon jammon mentioned this pull request Oct 14, 2018
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@weeman1337 weeman1337 Awaiting requested review from weeman1337

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dependencies feature: settings feature: vue apps regression
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @jancborchardt @blizzz @MorrisJobke @rullzer