Revert "Wait for cron to finish before running upgrade command" #12188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2018
skjnldsv
approved these changes
Nov 1, 2018
Disagree, in general it is a good idea and valid approach, unfortunately it was not solid enough this way. |
blizzz
approved these changes
Nov 1, 2018
That's what I meant xD |
MorrisJobke
force-pushed
the
revert/9900/revert-wait-for-cron
branch
from
1be3cb8
to
c15ece1
Compare
This reverts commit 18e9631. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
revert/9900/revert-wait-for-cron
branch
from
c15ece1
to
f5a1f4b
Compare
|
I just added the sign-off message 🙈 |
MorrisJobke
added
4. to release
|
Backport is in #12197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 18e9631.
Reverts #9900
Fixes #9992
It was not a good idea to check for that and until we run into serious problems with this we should be fine.