Fix UniqueConstraintViolationException while insert into oc_groups #12419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes race condition in insert * fixes potentiaol deadlock Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
rullzer,
nickvergessen,
icewind1991,
schiessle,
blizzz,
kesselb and
violoncelloCH
This was referenced Nov 12, 2018
Merged
kesselb
approved these changes
Nov 12, 2018
blizzz
approved these changes
Nov 12, 2018
JanDragon
approved these changes
Nov 12, 2018
MorrisJobke
deleted the
bugfix/noid/group-creation-replace-insertIfNotExist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the other related PRs I would not backport this one as there is no bug report for a race condition or deadlock on those methods.