New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return the correct value when trying to get a non existing item from cache by id #12494

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Copy link
Member

icewind1991 commented Nov 16, 2018

Signed-off-by: Robin Appelman robin@icewind.nl

return the correct value when trying to get a non existing item from …
…cache by id

Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 15 milestone Nov 16, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Nov 16, 2018

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 19, 2018

@icewind1991 How to test this?

add test for non existing file by id
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991

This comment has been minimized.

Copy link
Member

icewind1991 commented Nov 19, 2018

@MorrisJobke I ran into this while working on the versions implementation for group folders, afaik there is no existing code running into this issue. Added a test case to cover it

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit cc6c30e into master Nov 20, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the cache-notfound-id branch Nov 20, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment