Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix rendering of the sidebar in Files app #12577
When a view is rendered it should not be concerned with where it is going to be placed in the document; in general this should be a responsibility of the object using the view.
Moreover, when the details view is rendered it should simply prepare a skeleton that includes the root elements provided by the plugins; those elements will be updated by the plugins as needed when a file or a tab is selected.
Finally, the details view should not be explicitly rendered. The rendering removes the previous elements, but that is needed only when the details view is in a dirty state, that is, when new plugins were added since the last time that it was rendered. However, that dirty state is internally handled, and the view is automatically rendered again if needed when a file info is set.
Due to all that the details view is no longer explicitly rendered when updating it with a different file. Also, as each file list has its own details view, and each details view has its own element, but there can be only one details view/sidebar element in the document, when the file list updates the details view it also replaces the current one in the document with its own details view if needed (that is, if it is not the current one already).
Besides that, when the element of a details view is replaced with the element of a different details view the old one should be detached from the document, but never removed. Otherwise the event handlers would not work when that element is attached again later (when changing to a different section in the Files app and then going back to the previous one).
Essentially the problems with buttons not working come from this last point (which was also increased by rendering the details view after setting the file info). Excuse me for not giving more details, but it is quite late ;-) (yes, late, not early; for me it is still yesterday :-P ).
Nevertheless, for reference here is the explanation of what was the problem with comments: it did not come from rendering the view twice, but from setting the file info for one file and then setting the file info for a different file almost immediately; rendering the details view after setting the file info fixed the problem only because the same file info was set twice ;-)
Due to all that it may be possible that further bugs with the comments are lurking in the shadows, but in most cases it should work fine ;-)
I have added acceptance tests for the issue that was fixed by #12231 (comments), issues caused by #12231 (favoriting from the details view), and issues caused (or, at least, not yet fixed) by #10509 (tags and opening and closing the details view). Note, however, that the tests for tags still fail sometimes due to a race condition; this is another issue to be fixed in a different pull request.