Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Base64 from 0.3.0 to 1.0.1 #13460

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps Base64 from 0.3.0 to 1.0.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much has changed 👍

@ChristophWurst ChristophWurst force-pushed the dependabot/npm_and_yarn/Base64-1.0.1 branch from 2247dc9 to 68700ab Compare January 9, 2019 19:54
Bumps [Base64](https://github.com/davidchambers/Base64.js) from 0.3.0 to 1.0.1.
- [Release notes](https://github.com/davidchambers/Base64.js/releases)
- [Commits](davidchambers/Base64.js@0.3.0...1.0.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the dependabot/npm_and_yarn/Base64-1.0.1 branch from 68700ab to 1dc2f22 Compare January 10, 2019 14:03
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 10, 2019
@ChristophWurst
Copy link
Member

In the light of my own todo comment

server/core/src/main.js

Lines 22 to 23 in 27f492a

// TODO: not required anymore https://caniuse.com/#search=atob
import 'Base64'
, shall we just remove it? https://caniuse.com/#search=atob
cc @nextcloud/javascript

@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jan 10, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Jan 10, 2019
@juliushaertl
Copy link
Member

juliushaertl commented Jan 10, 2019

, shall we just remove it? caniuse.com/#search=atob

Yes, lets just get rid of it then 🔥

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@ChristophWurst ChristophWurst deleted the dependabot/npm_and_yarn/Base64-1.0.1 branch January 10, 2019 15:40
@ChristophWurst ChristophWurst removed this from the Nextcloud 16 milestone Jan 10, 2019
ChristophWurst added a commit that referenced this pull request Jan 10, 2019
Ref #13460 (comment)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member

-> #13491

ChristophWurst added a commit that referenced this pull request Jan 11, 2019
Ref #13460 (comment)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this pull request Jan 11, 2019
Ref #13460 (comment)

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: dependencies javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants