Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefetching blows up if there are a lot of files. #15146

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Prefetching blows up if there are a lot of files. #15146

merged 1 commit into from
Apr 24, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 17, 2019

I saw instances where people had a lot of files (each with custom
properties) and all this prefetching blew up and started to consume an
insane amount of RAM resulting in the process getting killed.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added bug 3. to review Waiting for reviews labels Apr 17, 2019
@rullzer rullzer added this to the Nextcloud 17 milestone Apr 17, 2019
@rullzer
Copy link
Member Author

rullzer commented Apr 17, 2019

/backport to stable16

@rullzer
Copy link
Member Author

rullzer commented Apr 17, 2019

/backport to stable15

@rullzer
Copy link
Member Author

rullzer commented Apr 17, 2019

/backport to stable14

MorrisJobke
MorrisJobke approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
Copy link
Member

CI fails:

There was 1 failure:

1) OCA\DAV\Tests\unit\Connector\Sabre\CustomPropertiesBackendTest::testGetPropertiesForDirectory
Expectation failed for method name is equal to "getChildren" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

@rullzer rullzer force-pushed the fix/customer_properties_boom branch from 5523869 to c16d116 Compare April 18, 2019 19:22
@rullzer
Prefetching blows up if there are a lot of files.
c16d116 
I saw instances where people had a lot of files (each with custom
properties) and all this prefetching blew up and started to consume an
insane amount of RAM resulting in the process getting killed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer merged commit 38adda4 into master Apr 24, 2019
@rullzer rullzer deleted the fix/customer_properties_boom branch April 24, 2019 07:00
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 24, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #15204

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 24, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable15 in #15206

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 24, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable14 in #15207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @ChristophWurst