Fix userid casting in notifications

[skjnldsv]

Fix #15677

[skjnldsv]

/backport to stable16

[skjnldsv]

@ChristophWurst this is what we should do right?
use \string to force php to not check for existing string class?

Because tests are failing
PHP Fatal error: Scalar type declaration 'string' must be unqualified in /drone/src/lib/private/Notification/Notification.php on line 136

[ChristophWurst]

@ChristophWurst this is what we should do right?

Not for primitive types. Only for built-in functions like \count it does make sense.

[skjnldsv]

Yep, I just realised that ^^
Fixed!

[backportbot-nextcloud]

backport to stable16 in #15925

[kesselb]

cc @corecode

[corecode]

thanks!

[juliushaertl]

@skjnldsv Tests are still failing due to this on master. Mind to have a look?

1) Test\Notification\NotificationTest::testSetAppInvalid with data set #0 (true)
--
152 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
153 |  
154 | 2) Test\Notification\NotificationTest::testSetAppInvalid with data set #2 (0)
155 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
156 |  
157 | 3) Test\Notification\NotificationTest::testSetAppInvalid with data set #3 (1)
158 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
159 |  
160 | 4) Test\Notification\NotificationTest::testSetAppInvalid with data set #5 (array())
161 | Failed asserting that exception of type "TypeError" matches expected exception "\InvalidArgumentException". Message was: "Argument 1 passed to OC\Notification\Notification::setApp() must be of the type string, array given, called in /drone/src/tests/lib/Notification/NotificationTest.php on line 108" at
162 | /drone/src/lib/private/Notification/Notification.php:137
163 | /drone/src/tests/lib/Notification/NotificationTest.php:108
164 | .
165 |  
166 | 5) Test\Notification\NotificationTest::testSetAppInvalid with data set #7 (array('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'))
167 | Failed asserting that exception of type "TypeError" matches expected exception "\InvalidArgumentException". Message was: "Argument 1 passed to OC\Notification\Notification::setApp() must be of the type string, array given, called in /drone/src/tests/lib/Notification/NotificationTest.php on line 108" at
168 | /drone/src/lib/private/Notification/Notification.php:137
169 | /drone/src/tests/lib/Notification/NotificationTest.php:108
170 | .
171 |  
172 | 6) Test\Notification\NotificationTest::testSetUserInvalid with data set #0 (true)
173 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
174 |  
175 | 7) Test\Notification\NotificationTest::testSetUserInvalid with data set #2 (0)
176 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
177 |  
178 | 8) Test\Notification\NotificationTest::testSetUserInvalid with data set #3 (1)
179 | Failed asserting that exception of type "\InvalidArgumentException" is thrown.
180 |  
181 | 9) Test\Notification\NotificationTest::testSetUserInvalid with data set #5 (array())
182 | Failed asserting that exception of type "TypeError" matches expected exception "\InvalidArgumentException". Message was: "Argument 1 passed to OC\Notification\Notification::setUser() must be of the type string, array given, called in /drone/src/tests/lib/Notification/NotificationTest.php on line 136" at
183 | /drone/src/lib/private/Notification/Notification.php:159
184 | /drone/src/tests/lib/Notification/NotificationTest.php:136
185 | .
186 |  
187 | 10) Test\Notification\NotificationTest::testSetUserInvalid with data set #7 (array('aaaaaaaaaaaaaaaaaaaaaaaaaaaaa...aaaaaa'))
188 | Failed asserting that exception of type "TypeError" matches expected exception "\InvalidArgumentException". Message was: "Argument 1 passed to OC\Notification\Notification::setUser() must be of the type string, array given, called in /drone/src/tests/lib/Notification/NotificationTest.php on line 136" at
189 | /drone/src/lib/private/Notification/Notification.php:159
190 | /drone/src/tests/lib/Notification/NotificationTest.php:136
191 | .

[skjnldsv]

Ah damn, I missed those!
Thanks!

[nickvergessen]

the type hint is also part of #15040

Also I would suggest to revert the backport of the type hint and only keep the cast in 16, which also already fixes the problem.

[skjnldsv]

@nickvergessen sure thing!
Do whatever you need :)