New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(UpdateNotifications): Handle numeric user ids #44093
Conversation
Closes #44051 Signed-off-by: Josh <josh.t.richards@gmail.com>
@@ -121,7 +121,7 @@ | |||
->setSubject('connection_error', ['days' => $numDays]); | |||
|
|||
foreach ($this->getUsersToNotify() as $uid) { | |||
$notification->setUser($uid); | |||
$notification->setUser((string) $uid); |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
@@ -189,7 +189,7 @@ | |||
} | |||
|
|||
foreach ($this->getUsersToNotify() as $uid) { | |||
$notification->setUser($uid); | |||
$notification->setUser((string) $uid); |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
This is no longer the case, |
28 and lower with the bug is fixed via #44095 |
Summary
getUsersToNotify()
usesarray_key
so when$uid
happens to be numeric it ends up needing to be cast here (similar to #15912).Backports will need to be done manually due to restructure that occurred in >v28 (I'll follow-up with those).
TODO
Checklist