Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Encryption.php #15946

Merged

Conversation

martink-p
Copy link
Contributor

@martink-p martink-p commented Jun 13, 2019

Fix #9792
Pull request for a working solution of issue #9792 (#9792)

@kesselb kesselb added 3. to review Waiting for reviews bug labels Jun 13, 2019
@kesselb kesselb added this to the Nextcloud 17 milestone Jun 13, 2019
@kesselb
Copy link
Contributor

kesselb commented Jun 13, 2019

Ref owncloud/core#34599 and owncloud/core#35519 for some more details

martink-p and others added 4 commits June 17, 2019 12:13
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
Co-Authored-By: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
Signed-off-by: martink-p <47943787+martink-p@users.noreply.github.com>
@martink-p martink-p force-pushed the bugxfix/9792/encrypted-external-webdav branch from 04ad7ed to 9cff71f Compare June 17, 2019 10:14
@MorrisJobke MorrisJobke mentioned this pull request Jul 15, 2019
28 tasks
Copy link
Member

@schiessle schiessle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martink-p thanks for your pull request! Looks good to me and makes absolutely sense.

@rullzer rullzer merged commit d14aed1 into nextcloud:master Aug 15, 2019
@welcome
Copy link

welcome bot commented Aug 15, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
4 participants