Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Encryption.php to fix issue #34599 "encrypted remote storage" #35519

Conversation

martink-p
Copy link
Contributor

@martink-p martink-p commented Jun 13, 2019

Description

The details of my change are described in #34599. However, in principle it adds a wrapper function to "stream_read" which reads (and checks) until the required block size is available or there is no remaining data.

Related Issue

Motivation and Context

This pull request fixes an issue with encrypted external WebDAV storage an was verified as a soluition with nextcloud issue nextcloud/server#9792

How Has This Been Tested?

  • test environment: running owncloud docker system with external WebDAV storage at Strato HiDrive
  • test case 1: several files. uploaded, checked encryption, downloaded, checked decryption.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2019

CLA assistant check
All committers have signed the CLA.

@martink-p martink-p changed the title Update Encryption.php to fix issue #34599 "encrypted remote storage" Update Encryption.php to fix issue #34599 "encrypted remote storage" 3 - To review Jun 13, 2019
@martink-p martink-p changed the title Update Encryption.php to fix issue #34599 "encrypted remote storage" 3 - To review Update Encryption.php to fix issue #34599 "encrypted remote storage" Jun 13, 2019
@DeepDiver1975
Copy link
Member

As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase.

This PR targetted ownCloud 11 which is postponed to a far distant future.

Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days.

Thanks a lot for your patience

@martink-p martink-p deleted the bugfix/34599/encrypted-external-webdav branch September 10, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream_read not returning the requested length for encrypted remote storage
3 participants