Add update all button to the app list

[GretaD]

Fix #6989

[skjnldsv]

See comments

[gary-kim]

This is going to make managing an install much easier. Thank you.

[gary-kim]

Suggested change

	return this.hasPendingUpdate && ['installed', 'updates'].indexOf(this.category) !== -1
	return this.hasPendingUpdate && ['installed', 'updates'].includes(this.category)

[skjnldsv]

Great work :)
See others comments ;)

[kesselb]

[kesselb]

1. The "Update all" button is only visible on the "your apps" page.

2. server/settings/Controller/AppSettingsController.php

   Line 263 in 769cb62
   Add $appData['update'] = '19.0.1'; above to show the update button for every app and then press the update all button. The result is a password confirmation box for every app with an update. forEach is blocking but the dispatch method not. I don't think we can wait for a event emitted by dispatch so the requiredAdmin call needs to be done before the emit to show only one password confirmation box.

3. Current implementation will update the apps at the same time. I'm not sure if this is a good idea. A new "updateAll" route would be more stable.

[skjnldsv]

2. I don't think we can wait for a event emitted by dispatch so the requiredAdmin call needs to be done before the emit to show only one password confirmation box.

Yes, we can :)
https://github.com/nextcloud/contacts/blob/380cda3c6a43f7a49ea8cd31869ba276c458c702/src/components/Settings/SettingsAddressbook.vue#L186

@GretaD

[GretaD]

1. The "Update all" button is only visible on the "your apps" page.

You propose to be also in other pages? Currently is at "your apps" and "Update" page.

[kesselb]

You propose to be also in other pages? Currently is at "your apps" and "Update" page.

I did but changed my mind now 🤣 I guess if we add the update all button to the disabled apps page people would expect that only disabled apps are updated and the same for active apps. But this is to complex so your apps and updates is fine.

[georgehrke]

The result is a password confirmation box for every app with an update. forEach is blocking but the dispatch method not. I don't think we can wait for a event emitted by dispatch so the requiredAdmin call needs to be done before the emit to show only one password confirmation box.

2. I don't think we can wait for a event emitted by dispatch so the requiredAdmin call needs to be done before the emit to show only one password confirmation box.

Yes, we can :)
https://github.com/nextcloud/contacts/blob/380cda3c6a43f7a49ea8cd31869ba276c458c702/src/components/Settings/SettingsAddressbook.vue#L186

@skjnldsv But you are inside an forEach loop. So even if the callback inside the foreach loop is returning a promise, it will happily ignore that and just call the next callback.

Leaving us with two options:

1. Solve this problem in javascript:

• add p-limit as dependency
• limit concurrent app-updates to one at a time.
• See for an example: https://github.com/nextcloud/contacts/blob/380cda3c6a43f7a49ea8cd31869ba276c458c702/src/store/addressbooks.js#L399L409

2. Solve this problem in php:

• Just add a dedicated route that updates all apps with one request.

I would personally prefer 1.

@skjnldsv @kesselb ^

[kesselb]

@GretaD could you rebase? ;)

[GretaD]

@GretaD could you rebase? ;)

darn, i thought i already did

[skjnldsv]

darn, i thought i already did

Because lots of changes went into server again :)

/settings is now in /apps/settings