Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix users table overlaping with storage location #17203

Closed
wants to merge 1 commit into from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 18, 2019

fix #16076

"Language" dropdowns in the list overlap with next colum entries like "Storage location" if they are enabled

Used to be like this:
old_users_page

Now it looks like this:
new_version_users

we can improve it more in the future if necessary but for now its better that it was

@GretaD GretaD force-pushed the bugfix/16076/fix_usertable_overlaping branch from 3eb5506 to b8293b4 Compare September 18, 2019 21:23
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD force-pushed the bugfix/16076/fix_usertable_overlaping branch from 4461bbd to 2cee0a7 Compare September 18, 2019 21:39
.userBackend,
.lastLogin {
min-width: $grid-col-min-width;
min-width: 79px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a dedicated variable next to the ones in line 1346 :)

Copy link
Contributor Author

@GretaD GretaD Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv this bug will be fixed with PR ref #17239. Should I fix it also separately in this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use #17239 instead yes :)

@rullzer rullzer added 2. developing Work in progress bug labels Sep 23, 2019
@rullzer rullzer added this to the Nextcloud 18 milestone Sep 23, 2019
@GretaD
Copy link
Contributor Author

GretaD commented Sep 30, 2019

the overlapping will be fixed with this PR #17239, so Im closing this one.

@GretaD GretaD closed this Sep 30, 2019
@skjnldsv skjnldsv deleted the bugfix/16076/fix_usertable_overlaping branch September 30, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Nextcloud 17 polishing list!
3 participants