-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds possibility to set user documentation l10n. #17870
Conversation
Signed-off-by: pierreozoux <pierre@ozoux.net>
0efb9dd
to
b68562b
Compare
Hmm. |
@kesselb I just checked, removing images and zipping the user_manual folder, it weights only 35105bits. So adding one language documentation, is just 35kb, adding the ~100language would add 3.5mb. I agree that size does matter, and it is important for various reasons, but I propose that we discuss about it in another issue. |
@@ -67,15 +76,35 @@ public function __construct( | |||
* @NoAdminRequired | |||
*/ | |||
public function help(string $mode = 'user'): TemplateResponse { | |||
$this->navigationManager->setActiveEntry('help'); | |||
define('TRANSLATED_LANGUAGES', array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a class member. e.g: private const TRANSLATED_LANGUAGES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also prefer a better name like DOCUMENTATION_LANGUAGES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix when in front of computer, thanks for the advice.
Just had a look at |
Agree, I'll remove the DE, and check the brazilian. About the app, Im maybe biased because I don't want to create a repo, create an app, write tests, write a CICD pipeline and maintain an app for this 5 lines PR, but I think Nextcliud has to be consistent. Currently Nextcloud ships i18n for the app itself and the documentation. So to be consistent, I think it has to ship the documentation translated too. But again, I think this is another discussion than this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm strongly against doing this until there is a proper way to have translated documentation somehow kept up to date with the English one. Current de and pt_BR didn't receive an update in the last half year.
Besides that, maybe we should find a way to not ship the duplicate documentations (with images) as individual folders but somehow just have the text translations?
Well :) the english documentation is not that up to date either ;) https://github.com/nextcloud/documentation/blob/master/user_manual/whats_new.rst (check the date of the last change) Im also tackling this translation thing here nextcloud/documentation#216 (comment) I'm not asking to merge right away, I'm asking for a bit of support to help me roll the ball around this topic:) thanks for your help :) The next thing I need is to understand, where is the CI that packages the Nextcloud zip and fetch documentations so I can make sure it fetches the right thing at the right time. |
I'd say let's close this for now. This hasn't received any update in quite a while and this is something that needs to be discussed more. |
@ChristophWurst I'm still waiting nextcloud/documentation#1824 to be merged first. Can we keep it open? (and help move the other one?) |
So :) Now we have an automated way to translate documentation \o/ But it is still not shipped inside Nextcloud: (this screenshot is 18.0.14) I have a simple question, where (I searched) is the line that adds the documentation inside the Nextcloud zip? I just need the answer to that, and then I'll do the necessary PR that is needed to be solved before this PR :) |
Hey @pierreozoux seems like this PR is quite old and the direction since changed. Thanks for the interest in Nextcloud and the effort put into this! 🙇 |
I still need to figure out how is the documentation shipped in the Nextcloud package, so I can make sure that pt, fr and de are also shipped.
Relates to nextcloud/documentation#216
Thanks for your help!