Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move scroll container to inner element #18615

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Move scroll container to inner element #18615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 15 additions & 5 deletions core/css/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@
}
}

@mixin header-menu-height() {
min-height: calc(44px * 1.5); // show at least 1.5 entries
max-height: calc(100vh - #{$header-height} * 2);
}

#header {
/* Header menu */
$header-menu-entry-height: 44px;
Expand All @@ -88,13 +93,10 @@
z-index: 2000;
position: absolute;
max-width: 350px;
min-height: calc(44px * 1.5); // show at least 1.5 entries
max-height: calc(100vh - #{$header-height} * 2);
@include header-menu-height();
right: 5px; // relative to parent
top: $header-height;
margin: 0;
overflow-y: scroll;
-webkit-overflow-scrolling: touch;

&:not(.popovermenu) {
display: none;
Expand All @@ -113,9 +115,17 @@
right: 10px;
}

#apps > ul,
& > div,
& > ul {
overflow-y: auto;
-webkit-overflow-scrolling: touch;
@include header-menu-height();
}

/* Use by the apps menu and the settings right menu */
#apps > ul,
&.settings-menu {
&.settings-menu > ul {
li {
a {
display: inline-flex;
Expand Down