Require to use at least desktop client 2.0 by default #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @carlaschroder to be potential reviewers. |
| @@ -68,7 +68,7 @@ public function beforeHandler(RequestInterface $request) { | |||
| return; | |||
| } | |||
|
|
|||
| $minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '1.7.0'); | |||
| $minimumSupportedDesktopVersion = $this->config->getSystemValue('minimum.supported.desktop.version', '2.0.0'); | |||
There was a problem hiding this comment.
Btw sure we can allow people to require more up to date versions.
But should we have 2.0.0 as a minimum as well, so when someone copied sample.config.php he now still requires 2.0.0?
There was a problem hiding this comment.
As long as we have no pacakges for all platforms lets just keep this as is :)
|
👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @LukasReschke @nickvergessen @rullzer @karlitschek