Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow apps to provide Calendars in user's calendarHome #19196

Merged

Conversation

georgehrke
Copy link
Member

@georgehrke georgehrke commented Jan 29, 2020

@georgehrke georgehrke added the 2. developing Work in progress label Jan 29, 2020
@georgehrke georgehrke added this to the Nextcloud 19 milestone Jan 29, 2020
@georgehrke georgehrke force-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from a4ec37a to 47e661c Compare January 30, 2020 10:29
@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2020
@georgehrke
Copy link
Member Author

CI looks good, just some random acceptance tests that failed.

@georgehrke georgehrke force-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from 47e661c to 21d8f0f Compare January 31, 2020 20:46
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works great 👍

Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from 21d8f0f to b46e5cb Compare February 18, 2020 13:35
@rullzer rullzer merged commit 713d3d4 into master Feb 23, 2020
@rullzer rullzer deleted the feature/17126/allow_apps_to_register_their_own_calendars branch February 23, 2020 16:00
@juliushaertl
Copy link
Member

juliushaertl commented Feb 23, 2020

@georgehrke We need an update of the info.xml schema descriptions as well for the new calendar-plugins entry.

@rullzer
Copy link
Member

rullzer commented Feb 23, 2020

@georgehrke I suggest to do the same for contacts :)

This was referenced Feb 27, 2020
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
For #19795
For #19196
Ref nextcloud/appstore#673

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
For #19795
For #19196
Ref nextcloud/appstore#673

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow apps to register their own calendars to be exposed in user's calendar home
4 participants