Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to check share ACL's when listing directories #19399

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Add option to check share ACL's when listing directories #19399

merged 2 commits into from
Apr 22, 2020

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Feb 10, 2020
@icewind1991 icewind1991 added this to the Nextcloud 19 milestone Feb 10, 2020
@icewind1991 icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 10, 2020
@gogowitsch
Copy link

  1. I suggest to split this into topical commits. For example, I would prefer one for composer-related changes.

  2. Can you describe in more detail which install scenario and use case this PR solves? Thanks!

@icewind1991 icewind1991 changed the title dont show smb file/folder if read permissions is denied by acl Add option to check share ACL's when listing directories Apr 2, 2020
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 2, 2020
@icewind1991 icewind1991 mentioned this pull request Apr 2, 2020
Merged
This was referenced Apr 4, 2020
Merged
Merged
skjnldsv
skjnldsv approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts 💥

This was referenced Apr 15, 2020
Merged
Merged
@icewind1991
Copy link
Member Author

rebased, unit tests are happy

@icewind1991
Add option to check share ACL's when listing directories
23e2bae 
If a file or folder in a directory doesn't have read permissions they
will not be shown

Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.

Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)

Signed-off-by: Robin Appelman <robin@icewind.nl>
juliushaertl
juliushaertl approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me 👍

@juliushaertl
Copy link
Member

Failing php-cs check 😉

@icewind1991
add tooltip to option
7f32fe6 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@blizzz blizzz merged commit 4a8871f into master Apr 22, 2020
@blizzz blizzz deleted the smb-read-acl branch April 22, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@icewind1991 @gogowitsch @juliushaertl @skjnldsv @blizzz