LDAP Group Backend optimizations #19919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
force-pushed
the
enh/noid/ldpa_group_perf
branch
2 times, most recently
from
ab9f13a
to
7d1f0ce
Compare
|
@blizzz 19? |
- less duplication - profiting of the same cache entry Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- saves some overhead costs - in some occasions saves LDAP requests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Keep a runtime cache of dn-id-mapping Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/ldpa_group_perf
branch
from
7d1f0ce
to
090c59f
Compare
blizzz
added
3. to review
blizzz
requested review from
ChristophWurst,
rullzer,
skjnldsv,
juliushaertl and
kesselb
blizzz
force-pushed
the
enh/noid/ldpa_group_perf
branch
from
090c59f
to
a530f6d
Compare
blizzz
force-pushed
the
enh/noid/ldpa_group_perf
branch
from
a530f6d
to
9f87a3f
Compare
rullzer
approved these changes
Apr 23, 2020
Aye! Lemme adjust the formatting commit for the remaining stuff the csfixer is complaining about and then merge |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
enh/noid/ldpa_group_perf
branch
from
9f87a3f
to
4babdc0
Compare
|
Failures seems unrelated |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some test scenarios I reduced page loading of users page over
20%40% (with 4k of groups), and OCS calls to fetch user details10% downstagnate (also with 4k groups). Extreme cases of course, but the changes make sense either way. In the end, it is also very individual, depending on the config and setup.