remove the requirement that everything that looks like a placeholder … #19932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is substituted While maybe not common, `$` is a valid option in config fields Signed-off-by: Robin Appelman <robin@icewind.nl>
kesselb
approved these changes
Mar 13, 2020
blizzz
approved these changes
Mar 15, 2020
|
@icewind1991 does it need a backport? |
|
/backport to stable18 |
|
/backport to stable17 |
|
backport to stable18 in #20021 |
|
The backport to stable17 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is substituted
While maybe not common,
$is a valid option in config fieldsFixes #15654