Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only catch anonymous OPTIONS for Office #20632

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Only catch anonymous OPTIONS for Office #20632

merged 1 commit into from
Apr 27, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Apr 24, 2020

Should do the trick and still work for the original issue with opening office files in subdirectories when mounting the WebDAV endpoint in Windows, but I cannot test that as I don't have a Windows/Office installation.

For #20624

Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextcloud returns a proper 401 instead of 404 for OPTIONS /remote.php/dav/principals/users/georg.
👍

Don't have a Windows machine to test the implications on Office though

@georgehrke
Copy link
Member

/backport to stable18

@georgehrke
Copy link
Member

/backport to stable17

@juliushaertl
Copy link
Member Author

At least when checking the access logs we had for #16739 it should still be fine with checking the user agent against /Microsoft Office/

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer added this to the Nextcloud 19 milestone Apr 24, 2020
@rullzer rullzer mentioned this pull request Apr 24, 2020
11 tasks
@backportbot-nextcloud
Copy link

backport to stable18 in #20680

@backportbot-nextcloud
Copy link

backport to stable17 in #20681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants