Add a magic wrapper to allow phpunit4 to run the code again #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @owncloud-bot and @PVince81 to be potential reviewers. |
nickvergessen
force-pushed
the
make-sure-tests-run-on-phpunit-4-again
branch
from
4fce534
to
0a4488c
Compare
nickvergessen
added a commit
that referenced
this pull request
Nov 15, 2016
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
changed the title
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
make-sure-tests-run-on-phpunit-4-again
branch
from
0a4488c
to
e76ef9a
Compare
|
Fixes the issue: nextcloud/gallery#172 |
|
Review please @oparoz @LukasReschke @MorrisJobke |
|
I love magic! 👍 |
|
This test PR proves that it fixes things: |
|
Fine by me. As long as we still have apps that need to support <NC11 👍 |
nickvergessen
added a commit
that referenced
this pull request
Nov 24, 2016
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review please @oparoz @LukasReschke @MorrisJobke