-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a magic wrapper to allow phpunit4 to run the code again #2137
Conversation
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @owncloud-bot and @PVince81 to be potential reviewers. |
4fce534
to
0a4488c
Compare
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
0a4488c
to
e76ef9a
Compare
Fixes the issue: nextcloud/gallery#172 |
Review please @oparoz @LukasReschke @MorrisJobke |
I love magic! 👍 |
This test PR proves that it fixes things: |
Fine by me. As long as we still have apps that need to support <NC11 👍 |
Remove this once phpunit 5 is the lowest supported version, by reverting: #2137 Signed-off-by: Joas Schilling <coding@schilljs.com>
Review please @oparoz @LukasReschke @MorrisJobke