Fix S3 error handling #22514
Merged
Fix S3 error handling #22514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the object store errors we should not always delete the filecache entry. As this might lead to people losing access to their files. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
If we already update before we have no way to revert if the upload fails. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliushaertl
approved these changes
Aug 31, 2020
icewind1991
reviewed
Aug 31, 2020
| throw $ex; // make this bubble up | ||
| } | ||
|
|
||
| if (!$exists) { | ||
| if ($exists) { | ||
| $this->getCache()->update($fileId, $stat); |
There was a problem hiding this comment.
what stats are being updated here? the size is already updated in the CountWrapper callback
icewind1991
approved these changes
Aug 31, 2020
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
This was referenced Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.