Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable17] Fix S3 error handling #22523

Merged
merged 2 commits into from
Aug 31, 2020
Merged

[stable17] Fix S3 error handling #22523

merged 2 commits into from
Aug 31, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #22514

If the object store errors we should not always delete the filecache
entry. As this might lead to people losing access to their files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
If we already update before we have no way to revert if the upload
fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot
Copy link

faily-bot bot commented Aug 31, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32489: failure

webpack-build

integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log
  Scenario: Creating a new mail share        # /drone/src/build/integration/features/sharing-v1.feature:58
    Given dummy mail server is listening     # FeatureContext::dummyMailServerIsListening()
[Mon Aug 31 17:41:06 2020] 127.0.0.1:37234 [404]: /ocs/v2.php/cloud/users/user0
[Mon Aug 31 17:41:06 2020] 127.0.0.1:37268 [200]: /ocs/v1.php/cloud/users
[Mon Aug 31 17:41:06 2020] 127.0.0.1:37318 [200]: /ocs/v1.php/cloud/users/user0
[Mon Aug 31 17:41:06 2020] 127.0.0.1:37360 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                  # FeatureContext::assureUserExists()
    And As an "user0"                        # FeatureContext::asAn()
[Mon Aug 31 17:41:07 2020] {"Exception":"Swift_TransportException","Message":"Connection could not be established with host 127.0.0.1 [Connection refused #111]","Code":0,"Trace":[{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","line":58,"function":"establishSocketConnection","class":"Swift_Transport_StreamBuffer","type":"->","args":[]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/AbstractSmtpTransport.php","line":143,"function":"initialize","class":"Swift_Transport_StreamBuffer","type":"->","args":[{"protocol":"","host":"127.0.0.1","port":25,"timeout":10,"blocking":1,"tls":false,"type":1,"stream_context_options":[]}]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Mailer.php","line":65,"function":"start","class":"Swift_Transport_AbstractSmtpTransport","type":"->","args":[]},{"file":"\/drone\/src\/lib\/private\/Mail\/Mailer.php","line":185,"function":"send","class":"Swift_Mailer","type":"->","args":[{"__class__":"Swift_Message"},[]]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":444,"function":"send","class":"OC\\Mail\\Mailer","type":"->","args":[{"__class__":"OC\\Mail\\Message"}]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":356,"function":"sendMailNotification","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":["welcome.txt","http:\/\/localhost:8080\/index.php\/s\/BdSfMs7JaEbkt2H","user0","dumy@test.com",null]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":186,"function":"createMailShare","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/Share20\/Manager.php","line":700,"function":"create","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/apps\/files_sharing\/lib\/Controller\/ShareAPIController.php","line":577,"function":"createShare","class":"OC\\Share20\\Manager","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":170,"function":"createShare","class":"OCA\\Files_Sharing\\Controller\\ShareAPIController","type":"->","args":[{"__class__":"OC\\Files\\Node\\File"},19,4,"dumy@test.com","false","",null,"",""]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":126,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files_Sharing\\Controller\\ShareAPIController","createShare",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/ocs\/v1.php","line":82,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/files_sharing\/api\/v1\/shares"]}],"File":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","Line":269,"CustomMessage":"Failed to send share by mail."}
[Mon Aug 31 17:41:07 2020] 127.0.0.1:37386 [401]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with               # FeatureContext::creatingShare()
      | path      | welcome.txt   |
      | shareType | 4             |
      | shareWith | dumy@test.com |
    Then the OCS status code should be "100" # FeatureContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &0000000026a99c4f0000000004169b1b (
          0 => '403'
      ) matches expected '100'.
    And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
    And last share can be downloaded         # FeatureContext::lastShareCanBeDownloaded()
[Mon Aug 31 17:41:07 2020] 127.0.0.1:37570 [200]: /ocs/v1.php/cloud/users/user0
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37674 [404]: /ocs/v2.php/cloud/users/user0
[Mon Aug 31 17:41:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37688 [401]: /remote.php/webdav/myFileToComment.txt
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37692 [207]: /remote.php/dav/systemtags/
[Mon Aug 31 17:41:08 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37724 [401]: /remote.php/webdav/myFileToTag.txt
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37736 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Mon Aug 31 17:41:08 2020] 127.0.0.1:37756 [404]: /remote.php/dav/calendars/admin/MyCalendar

@rullzer rullzer merged commit e7761b6 into stable17 Aug 31, 2020
@rullzer rullzer deleted the backport/22514/stable17 branch August 31, 2020 19:44
@rullzer rullzer mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants