Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Fix S3 error handling #22523

Merged
merged 2 commits into from
Aug 31, 2020
Merged

[stable17] Fix S3 error handling #22523

merged 2 commits into from
Aug 31, 2020

Commits on Aug 31, 2020

  1. Don't lose filecache entry on s3 overwrite error 

    If the object store errors we should not always delete the filecache
entry. As this might lead to people losing access to their files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @backportbot
    rullzer authored and backportbot[bot] committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    e2219b8 View commit details
    Browse the repository at this point in the history

  2. Only update the filecache entry once the file has been written to S3 

    If we already update before we have no way to revert if the upload
fails.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @backportbot
    rullzer authored and backportbot[bot] committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    0eeb1ea View commit details
    Browse the repository at this point in the history