Change free space calculation #22528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
ChristophWurst
approved these changes
Sep 1, 2020
go2sh
approved these changes
Sep 1, 2020
|
Are the trashbin tests failing on master too? |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/22475/trash-bin-size
branch
from
3552878
to
ac8051e
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32529: failuremysql8.0-php7.2Show full log |
kesselb
commented
Sep 1, 2020
| if ($key === 'filesystem_check_changes') { | ||
| return \OC\Files\Cache\Watcher::CHECK_ONCE; | ||
| } else { | ||
| return $config->getSystemValue($key, $default); | ||
| } | ||
| }); | ||
| $mockConfig |
icewind1991
approved these changes
Sep 2, 2020
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
This was referenced Sep 3, 2020
|
The backport to stable17 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22475
If neither
$userTrashbinSizenor$systemTrashbinSizeare defined we have:$configuredTrashbinSize = (-1 < 0) ? -1 : -1;,(bool)-1is true and the freespace is always-1 - $trashbinSize.That should work but no idea how it should be ;)