Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow: do not hide "matches" and "does not match" checkers #22533

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Flow: do not hide "matches" and "does not match" checkers #22533

merged 1 commit into from
Sep 1, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Sep 1, 2020 •
edited
Loading

  • they show up previously with "/" typed in the input field – end user needs to know about it
  • inconsistent with some other fields, that show it directly

Brought up in nextcloud/workflow_script#58

@blizzz
do not hide "matches" and "does not match" checkers
2a00c47 
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 3. to review Waiting for reviews feature: workflows papercut Annoying recurring issue with possibly simple fix. labels Sep 1, 2020
@blizzz blizzz added this to the Nextcloud 20 milestone Sep 1, 2020
@blizzz blizzz changed the title do not hide "matches" and "does not match" checkers Flow: do not hide "matches" and "does not match" checkers Sep 1, 2020
@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2020
@faily-bot
Copy link

faily-bot bot commented Sep 1, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32522: failure

mariadb10.4-php7.3

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\CacheTest::testExtended
Failed asserting that null matches expected 30.

/drone/src/tests/lib/Files/Cache/CacheTest.php:737

@blizzz blizzz merged commit f32c84a into master Sep 1, 2020
@blizzz blizzz deleted the fix/noid/rm-matcher-magic branch September 1, 2020 09:56
@rullzer rullzer mentioned this pull request Sep 3, 2020
Merged
21 tasks
@nickvergessen
Copy link
Member

/backport to stable19

@nickvergessen
Copy link
Member

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 21, 2020
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: workflows papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blizzz @nickvergessen @juliushaertl @skjnldsv