Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] Flow: do not hide "matches" and "does not match" checkers #22988

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 21, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22533

@backportbot-nextcloud backportbot-nextcloud bot added feature: workflows papercut Annoying recurring issue with possibly simple fix. labels Sep 21, 2020
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.4 milestone Sep 21, 2020
@nickvergessen
Copy link
Member

/compile amend /

- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Sep 22, 2020
@faily-bot
Copy link

faily-bot bot commented Sep 22, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33293: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Trashbin\Tests\StorageTest::testSingleStorageDeleteFileFail
Failed asserting that false is true.

/drone/src/apps/files_trashbin/tests/StorageTest.php:499

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #8 (OC\Files\Search\SearchBinaryOperator Object (...), array(0))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => '443'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

@rullzer rullzer mentioned this pull request Sep 28, 2020
@rullzer rullzer merged commit bd037f8 into stable19 Sep 28, 2020
@rullzer rullzer deleted the backport/22533/stable19 branch September 28, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: workflows papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants