Only disable zip64 if the size is known #22535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
nickvergessen,
MorrisJobke,
icewind1991,
ChristophWurst,
juliushaertl and
danxuliu
|
/backport to stable19 |
|
/backport to stable18 |
|
/backport to stable17 |
juliushaertl
approved these changes
Sep 1, 2020
nickvergessen
approved these changes
Sep 1, 2020
|
Mind adding the commit message as a comment in the code. Otherwise I'm sure someone will remove it some day |
icewind1991
approved these changes
Sep 1, 2020
Else we might run into the issue that for an external storage where the size is not known yet we do not use zip64. Which then of course fails on large zip files. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/zipstreamer_external_storage
branch
from
cc8da24
to
ab6bd79
Compare
nickvergessen
approved these changes
Sep 1, 2020
ChristophWurst
approved these changes
Sep 1, 2020
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Else we might run into the issue that for an external storage where the
size is not known yet we do not use zip64. Which then of course fails on
large zip files.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl