Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable17] Only disable zip64 if the size is known #22539

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #22535

Else we might run into the issue that for an external storage where the
size is not known yet we do not use zip64. Which then of course fails on
large zip files.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@faily-bot
Copy link

faily-bot bot commented Sep 1, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32538: failure

webpack-build

integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log
  Scenario: Creating a new mail share        # /drone/src/build/integration/features/sharing-v1.feature:58
    Given dummy mail server is listening     # FeatureContext::dummyMailServerIsListening()
[Tue Sep  1 14:21:35 2020] 127.0.0.1:46412 [404]: /ocs/v2.php/cloud/users/user0
[Tue Sep  1 14:21:35 2020] 127.0.0.1:46426 [200]: /ocs/v1.php/cloud/users
[Tue Sep  1 14:21:35 2020] 127.0.0.1:46452 [200]: /ocs/v1.php/cloud/users/user0
[Tue Sep  1 14:21:35 2020] 127.0.0.1:46480 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                  # FeatureContext::assureUserExists()
    And As an "user0"                        # FeatureContext::asAn()
[Tue Sep  1 14:21:35 2020] {"Exception":"Swift_TransportException","Message":"Connection could not be established with host 127.0.0.1 [Connection refused #111]","Code":0,"Trace":[{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","line":58,"function":"establishSocketConnection","class":"Swift_Transport_StreamBuffer","type":"->","args":[]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/AbstractSmtpTransport.php","line":143,"function":"initialize","class":"Swift_Transport_StreamBuffer","type":"->","args":[{"protocol":"","host":"127.0.0.1","port":25,"timeout":10,"blocking":1,"tls":false,"type":1,"stream_context_options":[]}]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Mailer.php","line":65,"function":"start","class":"Swift_Transport_AbstractSmtpTransport","type":"->","args":[]},{"file":"\/drone\/src\/lib\/private\/Mail\/Mailer.php","line":185,"function":"send","class":"Swift_Mailer","type":"->","args":[{"__class__":"Swift_Message"},[]]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":444,"function":"send","class":"OC\\Mail\\Mailer","type":"->","args":[{"__class__":"OC\\Mail\\Message"}]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":356,"function":"sendMailNotification","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":["welcome.txt","http:\/\/localhost:8080\/index.php\/s\/3rwzXT6dL2TjLbr","user0","dumy@test.com",null]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":186,"function":"createMailShare","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/Share20\/Manager.php","line":700,"function":"create","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/apps\/files_sharing\/lib\/Controller\/ShareAPIController.php","line":577,"function":"createShare","class":"OC\\Share20\\Manager","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":170,"function":"createShare","class":"OCA\\Files_Sharing\\Controller\\ShareAPIController","type":"->","args":[{"__class__":"OC\\Files\\Node\\File"},19,4,"dumy@test.com","false","",null,"",""]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":126,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files_Sharing\\Controller\\ShareAPIController","createShare",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/ocs\/v1.php","line":82,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/files_sharing\/api\/v1\/shares"]}],"File":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","Line":269,"CustomMessage":"Failed to send share by mail."}
[Tue Sep  1 14:21:35 2020] 127.0.0.1:46494 [401]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with               # FeatureContext::creatingShare()
      | path      | welcome.txt   |
      | shareType | 4             |
      | shareWith | dumy@test.com |
    Then the OCS status code should be "100" # FeatureContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &0000000016f9450100000000428f1cc6 (
          0 => '403'
      ) matches expected '100'.
    And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
    And last share can be downloaded         # FeatureContext::lastShareCanBeDownloaded()
[Tue Sep  1 14:21:36 2020] 127.0.0.1:46592 [200]: /ocs/v1.php/cloud/users/user0
[Tue Sep  1 14:21:36 2020] 127.0.0.1:46636 [404]: /ocs/v2.php/cloud/users/user0
[Tue Sep  1 14:21:36 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Sep  1 14:21:36 2020] 127.0.0.1:46654 [401]: /remote.php/webdav/myFileToComment.txt
[Tue Sep  1 14:21:37 2020] 127.0.0.1:46666 [207]: /remote.php/dav/systemtags/
[Tue Sep  1 14:21:37 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Sep  1 14:21:37 2020] 127.0.0.1:46676 [401]: /remote.php/webdav/myFileToTag.txt
[Tue Sep  1 14:21:37 2020] 127.0.0.1:46682 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Tue Sep  1 14:21:37 2020] 127.0.0.1:46692 [404]: /remote.php/dav/calendars/admin/MyCalendar

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated.

@juliushaertl juliushaertl added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 3, 2020
@rullzer rullzer merged commit c97fb53 into stable17 Sep 3, 2020
@rullzer rullzer deleted the backport/22535/stable17 branch September 3, 2020 06:41
@rullzer rullzer mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: external storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants