Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared storage optimizations #22867

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Shared storage optimizations #22867

merged 2 commits into from
Sep 17, 2020

Conversation

icewind1991
Copy link
Member

  • Don't check for updates for shared storages, let the source storage deal with that
  • Optimize instanceOfStorage('\OCP\Files\IHomeStorage')
  • Optimize initializing source storage

@icewind1991
disable update checking for shared storages
244fd6a 
update checking is already handled by the share source

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 15, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Sep 15, 2020
@MorrisJobke
Copy link
Member

Mind to fix the unit tests and the code style complaints?

@icewind1991
optimize View::getPath if we already know the storage id
cfde744 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@nextcloud nextcloud deleted a comment from faily-bot bot Sep 16, 2020
@icewind1991
Copy link
Member Author

done

MorrisJobke
MorrisJobke approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested and works 👍

@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
Merged
5 tasks
@rullzer rullzer merged commit b0c04a3 into master Sep 17, 2020
@rullzer rullzer deleted the shared-storage-init-less branch September 17, 2020 06:55
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @MorrisJobke @rullzer