Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan the shared external storage source on access #28377

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Scan the shared external storage source on access #28377

merged 1 commit into from
Sep 10, 2021

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 11, 2021 •
edited
Loading

Fix #23988
Regression from #22867

@skjnldsv skjnldsv self-assigned this Aug 11, 2021
@skjnldsv skjnldsv added this to the Nextcloud 23 milestone Aug 11, 2021
icewind1991
icewind1991 previously requested changes Aug 11, 2021
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should instead be done by changing the Watcher returned by SharedStorage::getWatcher.

It currently returns a NullWatcher since it assumes that the share source handles it's updating (which is true for non-external-storage shares).

@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv
Copy link
Member Author

/backport to stable22

@skjnldsv
Copy link
Member Author

/backport to stable21

@skjnldsv
Copy link
Member Author

/backport to stable20

@PVince81
Copy link
Member

@CarlSchwan can you check if this might be related to the issue you're looking into ? seems it's also about a mount not being considered properly.

@skjnldsv skjnldsv requested a review from a team August 19, 2021 13:55
@szaimen szaimen mentioned this pull request Aug 25, 2021
Closed
PVince81
PVince81 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine to me, but would be good to get confirmation from @icewind1991 also

icewind1991
icewind1991 previously requested changes Aug 26, 2021
View reviewed changes
apps/files_sharing/lib/SharedStorage.php Outdated Show resolved Hide resolved
CarlSchwan
CarlSchwan approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🙂

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2021

Failures unrelated

@q-wertz q-wertz mentioned this pull request Sep 7, 2021
Closed
@skjnldsv
Return proper watcher if SharedStorage originates from ExternalMount
719480a 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@szaimen szaimen merged commit 43fcd28 into master Sep 10, 2021
@szaimen szaimen deleted the fix/shared-ext-storage-scan branch September 10, 2021 08:12
This was referenced Sep 10, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@blizzz blizzz Awaiting requested review from blizzz

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: external storage feature: filesystem regression
Projects
None yet
Milestone
Nextcloud 23
Development

Successfully merging this pull request may close these issues.

Files uploaded to external storage not shown immediately in Webinterface in shared folders
6 participants
@skjnldsv @PVince81 @icewind1991 @juliushaertl @CarlSchwan @szaimen